Update gateways to latest (#529)

* Update generate-report.ts

* Update generate-report.ts

* file upload

* Apply suggestions from code review

Author: kamilkisiela

federation/scenarios/constant-vus-over-time/generate-report.ts

@@ -14,29 +14,30 @@ const {
   GITHUB_RUN_ID = "local",
 } = process.env;
 
-async function uploadImageToCloudflare(
-  filename: string,
-  filePath: string
-): Promise<string | null> {
-  if (!CF_IMAGES_LINK || !CF_IMAGES_TOKEN) {
-    return null;
-  }
-
+async function uploadImageToCloudflare(filename: string, filePath: string) {
+  console.log("Uploading image to cloudflare");
   const buffer = readFileSync(filePath);
   const blob = new Blob([buffer], { type: "image/png" });
   const form = new FormData();
 
   form.append("file", blob, filename);
 
-  return fetch(CF_IMAGES_LINK!, {
+  const res = await fetch(CF_IMAGES_LINK!, {
     method: "POST",
     body: form,
     headers: {
       Authorization: `Bearer ${CF_IMAGES_TOKEN}`,
     },
-  })
-    .then((res) => res.json())
-    .then((r) => r.result.variants[0]);
+  });
+
+  console.log(`Got a response from cloudflare (status=${res.status})`);
+
+  if (!res.ok) {
+    throw new Error(`Failed to upload image to Cloudflare: ${res.statusText}`);
+  }
+
+  const data = await res.json();
+  return data.result.variants[0];
 }
 
 function notEmpty<TValue>(value: TValue | null | undefined): value is TValue {
@@ -57,7 +58,10 @@ async function generateReport(artifactsRootPath: string) {
     withFileTypes: true,
   })
     .filter((r) => r.isDirectory() && !IGNORED_DIRS.includes(r.name))
-    .filter((r) => r.name.startsWith(process.env.SCENARIO_ARTIFACTS_PREFIX!))
+    .filter(
+      (r) =>
+        r.name.startsWith(process.env.SCENARIO_ARTIFACTS_PREFIX!)
+    )
     .map((r) => r.name);
 
   console.info(
@@ -73,6 +77,7 @@ async function generateReport(artifactsRootPath: string) {
   const reportsData = await Promise.all(
     foundDirectories.map(async (dirName) => {
       const fullPath = join(artifactsRootPath, dirName);
+      console.log(`Processing directory: ${fullPath}`);
       const jsonSummaryFilePath = join(fullPath, "./k6_summary.json");
 
       if (!existsSync(jsonSummaryFilePath)) {
@@ -135,6 +140,8 @@ async function generateReport(artifactsRootPath: string) {
     .filter(notEmpty)
     .sort((a, b) => b.rps - a.rps);
 
+  console.log(`Found ${validReportsData.length} valid reports`);
+
   const vega: vl.TopLevelSpec = {
     width: 600,
     height: 400,
@@ -196,7 +203,10 @@ async function generateReport(artifactsRootPath: string) {
           );
         }
 
-        const checks = v.jsonSummary.root_group.checks;
+        const checks: Array<{
+          fails: number;
+          name: string;
+        }> = v.jsonSummary.root_group.checks;
         const http200Check = checks.find(
           (c) => c.name === "response code was 200"
         );
@@ -207,6 +217,7 @@ async function generateReport(artifactsRootPath: string) {
           (c) => c.name === "valid response structure"
         );
 
+
         if (http200Check.fails > 0) {
           notes.push(`${http200Check.fails} non-200 responses`);
         }

federation/scenarios/ramping-vus/generate-report.ts

@@ -15,21 +15,29 @@ const {
 } = process.env;
 
 async function uploadImageToCloudflare(filename: string, filePath: string) {
+  console.log("Uploading image to cloudflare");
   const buffer = readFileSync(filePath);
   const blob = new Blob([buffer], { type: "image/png" });
   const form = new FormData();
 
   form.append("file", blob, filename);
 
-  return fetch(CF_IMAGES_LINK!, {
+  const res = await fetch(CF_IMAGES_LINK!, {
     method: "POST",
     body: form,
     headers: {
       Authorization: `Bearer ${CF_IMAGES_TOKEN}`,
     },
-  })
-    .then((res) => res.json())
-    .then((r) => r.result.variants[0]);
+  });
+
+  console.log(`Got a response from cloudflare (status=${res.status})`);
+
+  if (!res.ok) {
+    throw new Error(`Failed to upload image to Cloudflare: ${res.statusText}`);
+  }
+
+  const data = await res.json();
+  return data.result.variants[0];
 }
 
 function notEmpty<TValue>(value: TValue | null | undefined): value is TValue {
@@ -186,13 +194,21 @@ async function generateReport(artifactsRootPath: string) {
         const notes: string[] = [];
 
         if (v.jsonSummary.metrics.http_req_failed.values.passes > 0) {
-          notes.push(`${v.jsonSummary.metrics.http_req_failed.values.passes} failed requests`);
+          notes.push(
+            `${v.jsonSummary.metrics.http_req_failed.values.passes} failed requests`
+          );
         }
 
         const checks = v.jsonSummary.root_group.checks;
-        const http200Check = checks.find(c => c.name === 'response code was 200');
-        const graphqlErrors = checks.find(c => c.name === 'no graphql errors');
-        const responseStructure = checks.find(c => c.name === 'valid response structure');
+        const http200Check = checks.find(
+          (c) => c.name === "response code was 200"
+        );
+        const graphqlErrors = checks.find(
+          (c) => c.name === "no graphql errors"
+        );
+        const responseStructure = checks.find(
+          (c) => c.name === "valid response structure"
+        );
 
         if (http200Check.fails > 0) {
           notes.push(`${http200Check.fails} non-200 responses`);
@@ -203,7 +219,9 @@ async function generateReport(artifactsRootPath: string) {
         }
 
         if (responseStructure.fails > 0) {
-          notes.push(`non-compatible response structure (${responseStructure.fails})`);
+          notes.push(
+            `non-compatible response structure (${responseStructure.fails})`
+          );
         }
 
         return {
@@ -220,8 +238,8 @@ async function generateReport(artifactsRootPath: string) {
           )}ms, med: ${Math.round(
             v.jsonSummary.metrics.http_req_duration.values.med
           )}ms`,
-          notes: notes.length === 0 ? '✅' : '❌ ' + notes.join(', '),
-        }
+          notes: notes.length === 0 ? "✅" : "❌ " + notes.join(", "),
+        };
       }),
       {
         columns: [