feat: KnownDirectives rule (#28)

Author: saihaj

README.md

@@ -59,7 +59,7 @@ cargo add graphql-tools
 - [x] UniqueVariableNames
 - [x] NoUndefinedVariables
 - [x] NoUnusedVariables
-- [ ] KnownDirectives
+- [x] KnownDirectives
 - [ ] UniqueDirectivesPerLocation
 - [x] KnownArgumentNames
 - [x] UniqueArgumentNames

src/ast/ext.rs

@@ -1,7 +1,8 @@
 use std::collections::HashMap;
 
 use crate::static_graphql::query::{
-    self, FragmentSpread, OperationDefinition, SelectionSet, Type, Value, VariableDefinition,
+    self, Directive, FragmentSpread, OperationDefinition, SelectionSet, Type, Value,
+    VariableDefinition,
 };
 use crate::static_graphql::schema::{
     self, DirectiveDefinition, InputValue, InterfaceType, ObjectType, TypeDefinition, UnionType,
@@ -43,6 +44,7 @@ impl FieldByNameExtension for TypeDefinition {
 
 pub trait OperationDefinitionExtension {
     fn variable_definitions(&self) -> &[VariableDefinition];
+    fn directives(&self) -> &[Directive];
     fn selection_set(&self) -> &SelectionSet;
 }
 
@@ -64,6 +66,15 @@ impl OperationDefinitionExtension for OperationDefinition {
             OperationDefinition::Subscription(subscription) => &subscription.selection_set,
         }
     }
+
+    fn directives(&self) -> &[Directive] {
+        match self {
+            OperationDefinition::Query(query) => &query.directives,
+            OperationDefinition::SelectionSet(_) => &[],
+            OperationDefinition::Mutation(mutation) => &mutation.directives,
+            OperationDefinition::Subscription(subscription) => &subscription.directives,
+        }
+    }
 }
 
 pub trait SchemaDocumentExtension {

src/ast/operation_visitor.rs

@@ -172,7 +172,7 @@ fn visit_definitions<'a, Visitor, UserContext>(
 
 fn visit_directives<'a, Visitor, UserContext>(
     visitor: &mut Visitor,
-    directives: &Vec<Directive>,
+    directives: &[Directive],
     context: &mut OperationVisitorContext<'a>,
     user_context: &mut UserContext,
 ) where
@@ -431,7 +431,7 @@ fn visit_operation_definition<'a, Visitor, UserContext>(
     Visitor: OperationVisitor<'a, UserContext>,
 {
     visitor.enter_operation_definition(context, user_context, operation);
-    // DOTAN: Maybe we need to iterate directives as well? but i think graphql_parser does not have it at the moment?
+    visit_directives(visitor, operation.directives(), context, user_context);
     visit_variable_definitions(
         visitor,
         operation.variable_definitions(),

src/validation/rules/defaults.rs

@@ -1,12 +1,12 @@
 use crate::validation::validate::ValidationPlan;
 
 use super::{
-    FieldsOnCorrectType, FragmentsOnCompositeTypes, KnownArgumentNames, KnownFragmentNames,
-    KnownTypeNames, LeafFieldSelections, LoneAnonymousOperation, NoFragmentsCycle,
-    NoUndefinedVariables, NoUnusedFragments, NoUnusedVariables, OverlappingFieldsCanBeMerged,
-    PossibleFragmentSpreads, ProvidedRequiredArguments, SingleFieldSubscriptions,
-    UniqueArgumentNames, UniqueFragmentNames, UniqueOperationNames, UniqueVariableNames,
-    VariablesAreInputTypes,
+    FieldsOnCorrectType, FragmentsOnCompositeTypes, KnownArgumentNames, KnownDirectives,
+    KnownFragmentNames, KnownTypeNames, LeafFieldSelections, LoneAnonymousOperation,
+    NoFragmentsCycle, NoUndefinedVariables, NoUnusedFragments, NoUnusedVariables,
+    OverlappingFieldsCanBeMerged, PossibleFragmentSpreads, ProvidedRequiredArguments,
+    SingleFieldSubscriptions, UniqueArgumentNames, UniqueFragmentNames, UniqueOperationNames,
+    UniqueVariableNames, VariablesAreInputTypes,
 };
 
 pub fn default_rules_validation_plan() -> ValidationPlan {
@@ -32,6 +32,7 @@ pub fn default_rules_validation_plan() -> ValidationPlan {
     plan.add_rule(Box::new(UniqueArgumentNames::new()));
     plan.add_rule(Box::new(UniqueVariableNames::new()));
     plan.add_rule(Box::new(ProvidedRequiredArguments::new()));
+    plan.add_rule(Box::new(KnownDirectives::new()));
 
     plan
 }