feat: No Fragment Cycle Rule (#8)

Co-authored-by: Dotan Simha <[email protected]>

Author: saihaj

Cargo.lock

@@ -55,7 +55,7 @@ cargo add graphql-tools
 - [x] KnownFragmentNames
 - [x] NoUnusedFragments
 - [ ] PossibleFragmentSpreads
-- [ ] NoFragmentCycles
+- [x] NoFragmentCycles
 - [ ] UniqueVariableNames
 - [ ] NoUndefinedVariables
 - [ ] NoUnusedVariables

README.md

@@ -1,4 +1,4 @@
-use crate::static_graphql::query::{self};
+use crate::static_graphql::query::{self, FragmentSpread};
 use crate::static_graphql::schema::{
     self, Field, InterfaceType, ObjectType, TypeDefinition, UnionType,
 };
@@ -237,3 +237,37 @@ impl AstNodeWithName for query::FragmentDefinition {
         Some(self.name.clone())
     }
 }
+
+impl AstNodeWithName for query::FragmentSpread {
+    fn node_name(&self) -> Option<String> {
+        Some(self.fragment_name.clone())
+    }
+}
+
+pub trait FragmentSpreadExtraction {
+    fn get_recursive_fragment_spreads(&self) -> Vec<FragmentSpread>;
+    fn get_fragment_spreads(&self) -> Vec<FragmentSpread>;
+}
+
+impl FragmentSpreadExtraction for query::SelectionSet {
+    fn get_recursive_fragment_spreads(&self) -> Vec<FragmentSpread> {
+        self.items
+            .iter()
+            .flat_map(|v| match v {
+                query::Selection::FragmentSpread(f) => vec![f.clone()],
+                query::Selection::Field(f) => f.selection_set.get_fragment_spreads(),
+                query::Selection::InlineFragment(f) => f.selection_set.get_fragment_spreads(),
+            })
+            .collect()
+    }
+
+    fn get_fragment_spreads(&self) -> Vec<FragmentSpread> {
+        self.items
+            .iter()
+            .flat_map(|v| match v {
+                query::Selection::FragmentSpread(f) => vec![f.clone()],
+                _ => vec![],
+            })
+            .collect()
+    }
+}

src/ast/ext.rs

@@ -8,7 +8,7 @@
 pub mod ast;
 
 pub mod static_graphql {
-    macro_rules! static_graphql {
+  macro_rules! static_graphql {
     ($m:ident, $m2:ident, {$($n:ident,)*}) => {
         pub mod $m {
             use graphql_parser::$m2 as $m;
@@ -20,16 +20,16 @@ pub mod static_graphql {
     };
   }
 
-    static_graphql!(query, query, {
-      Document, Value, OperationDefinition, InlineFragment, TypeCondition,
-      FragmentSpread, Field, Selection, SelectionSet, FragmentDefinition,
-      Directive, VariableDefinition, Type, Query, Definition, Subscription, Mutation,
-    });
-    static_graphql!(schema, schema, {
-      Field, Directive, InterfaceType, ObjectType, Value, TypeDefinition,
-      EnumType, Type, Document, ScalarType, InputValue, DirectiveDefinition,
-      UnionType, InputObjectType, EnumValue, SchemaDefinition,
-    });
+  static_graphql!(query, query, {
+    Document, Value, OperationDefinition, InlineFragment, TypeCondition,
+    FragmentSpread, Field, Selection, SelectionSet, FragmentDefinition,
+    Directive, VariableDefinition, Type, Query, Definition, Subscription, Mutation,
+  });
+  static_graphql!(schema, schema, {
+    Field, Directive, InterfaceType, ObjectType, Value, TypeDefinition,
+    EnumType, Type, Document, ScalarType, InputValue, DirectiveDefinition,
+    UnionType, InputObjectType, EnumValue, SchemaDefinition,
+  });
 }
 
 pub mod validation;

src/lib.rs

@@ -5,6 +5,7 @@ pub mod known_fragment_names;
 pub mod known_type_names;
 pub mod leaf_field_selections;
 pub mod lone_anonymous_operation;
+pub mod no_fragments_cycle;
 pub mod no_unused_fragments;
 pub mod overlapping_fields_can_be_merged;
 /// Utilities validating GraphQL documents/operations
@@ -21,6 +22,7 @@ pub use self::known_fragment_names::*;
 pub use self::known_type_names::*;
 pub use self::leaf_field_selections::*;
 pub use self::lone_anonymous_operation::*;
+pub use self::no_fragments_cycle::*;
 pub use self::no_unused_fragments::*;
 pub use self::overlapping_fields_can_be_merged::*;
 pub use self::rule::*;