coordinate is never serialized, but should apear in error instance

Author: EmrysMyrddin

package.json

@@ -107,8 +107,8 @@
     },
     "overrides": {
       "axios": "1.13.2",
-      "@graphql-tools/executor": "1.5.0-alpha-20251113162628-fc5dd9a67f15da93da0f992ac3e357a9431c42bc",
-      "@graphql-tools/utils": "10.11.0-alpha-20251113162628-fc5dd9a67f15da93da0f992ac3e357a9431c42bc",
+      "@graphql-tools/executor": "1.5.0-alpha-20251120140925-6fcd4c6ff2d2eb40d5890db29418a15cc4cc3956",
+      "@graphql-tools/utils": "10.11.0-alpha-20251120140925-6fcd4c6ff2d2eb40d5890db29418a15cc4cc3956",
       "estree-util-value-to-estree": "3.5.0",
       "eslint-plugin-unicorn": "56.0.1",
       "esbuild": "0.25.12",

packages/graphql-yoga/__tests__/error-masking.spec.ts

@@ -1,3 +1,4 @@
+import { ExecutionResult, GraphQLError } from 'graphql';
 import { inspect } from '@graphql-tools/utils';
 import { createGraphQLError, createLogger, createSchema, createYoga } from '../src/index.js';
 import { useErrorCoordinate } from '../src/plugins/use-error-coordinate.js';
@@ -862,12 +863,17 @@ describe('error masking', () => {
   });
 
   it('should mask experimental coordinate error attribute on production env', async () => {
+    let error: GraphQLError | undefined;
     const yoga = createYoga({
       logging: false,
-      maskedErrors: {
-        isDev: true,
-      },
-      plugins: [useErrorCoordinate()],
+      plugins: [
+        useErrorCoordinate(),
+        {
+          onExecutionResult({ result }) {
+            error = (result as ExecutionResult).errors?.[0];
+          },
+        },
+      ],
       schema: createSchema({
         typeDefs: /* GraphQL */ `
           type Query {
@@ -888,46 +894,36 @@ describe('error masking', () => {
       }),
     });
 
-    const response = await yoga.fetch('http://yoga/graphql', {
+    const r1 = await yoga.fetch('http://yoga/graphql', {
       method: 'POST',
       headers: {
         accept: 'application/graphql-response+json',
         'content-type': 'application/json',
       },
       body: JSON.stringify({ query: '{ a }' }),
     });
+    const b1 = await r1.json();
 
-    const body = await response.json();
-    expect(response.status).toEqual(200);
-
-    expect(body).toMatchObject({
-      errors: [
-        {
-          message: 'Test Error',
-          coordinate: 'Query.a',
-        },
-      ],
+    expect(error).toMatchObject({
+      message: 'Test Error',
+      coordinate: 'Query.a',
     });
+    expect(b1.errors[0].coordinate).toBeUndefined();
 
-    const response2 = await yoga.fetch('http://yoga/graphql', {
+    const r2 = await yoga.fetch('http://yoga/graphql', {
       method: 'POST',
       headers: {
         accept: 'application/graphql-response+json',
         'content-type': 'application/json',
       },
       body: JSON.stringify({ query: '{ b }' }),
     });
+    const b2 = await r2.json();
 
-    const body2 = await response2.json();
-    expect(response2.status).toEqual(200);
-
-    expect(body2).toMatchObject({
-      errors: [
-        {
-          message: 'Unexpected error.',
-          coordinate: 'Query.b',
-        },
-      ],
+    expect(error).toMatchObject({
+      message: 'Unexpected error.',
+      coordinate: 'Query.b',
     });
+    expect(b2.errors[0].coordinate).toBeUndefined();
   });
 });

packages/graphql-yoga/src/utils/mask-error.ts

@@ -1,21 +1,7 @@
-import { GraphQLError, GraphQLFormattedError } from 'graphql';
 import { createGraphQLError, getSchemaCoordinate } from '@graphql-tools/utils';
 import { isGraphQLError, isOriginalGraphQLError } from '../error.js';
 import { MaskError } from '../types.js';
 
-// We override the `toJSON` function to mask coordinate, because otherwise, it will be entirely
-// masked for plugins after the onExecuteDone phase (which have an impact for telemetry for example)
-function toJsonWithoutCoordinate(this: GraphQLError): GraphQLFormattedError {
-  const toJSON: typeof GraphQLError.prototype.toJSON =
-    (this as { _originalToJSON?: typeof GraphQLError.prototype.toJSON })._originalToJSON ??
-    GraphQLError.prototype.toJSON;
-  const json = toJSON.apply(this);
-  // @ts-expect-error coordinate is readonly
-  delete json.coordinate;
-
-  return json;
-}
-
 function serializeError(error: unknown) {
   if (isGraphQLError(error)) {
     return error.toJSON();
@@ -36,12 +22,6 @@ export const maskError: MaskError = (
   isDev = globalThis.process?.env?.['NODE_ENV'] === 'development',
 ) => {
   if (isOriginalGraphQLError(error)) {
-    if (!isDev) {
-      Object.defineProperties(error, {
-        toJSON: { value: toJsonWithoutCoordinate },
-        _originalToJSON: { value: error.toJSON },
-      });
-    }
     return error;
   }
   const errorExtensions: Record<string, unknown> = {
@@ -67,20 +47,5 @@ export const maskError: MaskError = (
     errorExtensions['originalError'] = serializeError(error);
   }
 
-  const maskedError = createGraphQLError(message, errorOptions);
-
-  if (!isDev) {
-    Object.defineProperties(maskedError, {
-      toJSON: { value: toJsonWithoutCoordinate },
-      _originalToJSON: { value: maskedError.toJSON },
-    });
-    if (maskedError.extensions['originalError'] instanceof GraphQLError) {
-      Object.defineProperties(maskedError.extensions['originalError'], {
-        toJSON: { value: toJsonWithoutCoordinate },
-        _originalToJSON: { value: maskedError.extensions['originalError'].toJSON },
-      });
-    }
-  }
-
-  return maskedError;
+  return createGraphQLError(message, errorOptions);
 };