Avoid node-fetch on Node 16/18 temporarily & enable detectLeaks on tests (#1794)

* Avoid node-fetch on Node 16/18 temporarily & enable detectLeaks on tests

* Go

* Go

* Go

* Seperate Bun Tests

* Update Deno example

* Disable Apollo & Urql tests

* Try runInBand

* Log heap usage as well

* More

* chore(dependencies): updated changesets for modified dependencies

* Try CI

* Fix

* Fix bun tests

* ..

* chore(dependencies): updated changesets for modified dependencies

* Yes

* chore(dependencies): updated changesets for modified dependencies

* Go

* Go

* ..

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: ardatan

.changeset/@graphql-yoga_plugin-apollo-inline-trace-1794-dependencies.md

@@ -0,0 +1,7 @@
+---
+'@graphql-yoga/plugin-apollo-inline-trace': patch
+---
+
+dependencies updates:
+
+- Updated dependency [`@whatwg-node/[email protected]` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.4.6) (from `0.4.5`, in `dependencies`)

.changeset/@graphql-yoga_plugin-apq-1794-dependencies.md

@@ -0,0 +1,7 @@
+---
+'@graphql-yoga/plugin-apq': patch
+---
+
+dependencies updates:
+
+- Updated dependency [`@whatwg-node/[email protected]` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.4.6) (from `0.4.5`, in `dependencies`)

.changeset/graphql-yoga-1794-dependencies.md

@@ -0,0 +1,9 @@
+---
+'graphql-yoga': patch
+---
+
+dependencies updates:
+
+- Updated dependency [`@whatwg-node/[email protected]` ↗︎](https://www.npmjs.com/package/@whatwg-node/fetch/v/0.4.6) (from `0.4.5`, in `dependencies`)
+- Updated dependency [`@whatwg-node/[email protected]` ↗︎](https://www.npmjs.com/package/@whatwg-node/server/v/0.4.10) (from `0.4.7`, in `dependencies`)
+- Added dependency [`@graphql-tools/[email protected]` ↗︎](https://www.npmjs.com/package/@graphql-tools/utils/v/8.12.0) (to `dependencies`)

.github/workflows/ci.yml

@@ -11,15 +11,15 @@ on:
       - 'website/**'
 
 jobs:
-  node:
+  unit:
     name: unit / nodejs v${{ matrix.node-version }}
     uses: the-guild-org/shared-config/.github/workflows/ci-node-matrix.yml@main
     with:
       script: 'yarn build && yarn test'
       nodeVersions: '[14,16,18]'
 
-  test-integration:
-    name: Run integration tests
+  integration:
+    name: integration / nodejs v${{ matrix.node-version }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -35,9 +35,6 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'yarn'
 
-      - name: Setup Bun Runtime
-        uses: antongolub/action-setup-bun@v1
-
       - name: Cache Node Modules
         uses: actions/cache@v3
         id: node-modules-cache-test-node
@@ -54,10 +51,9 @@ jobs:
         run: yarn build
 
       - name: Run Tests
-        run: yarn test:integration
+        run: yarn test:integration --ci
 
-  test-esm:
-    name: esm
+  esm:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Repository
@@ -88,6 +84,9 @@ jobs:
       - name: Use Deno
         uses: denoland/setup-deno@v1
 
+      - name: Setup Bun Runtime
+        uses: antongolub/action-setup-bun@v1
+
       - name: Build Packages
         run: yarn build
 

README.md

@@ -51,7 +51,9 @@ const yoga = createYoga({
 
 const server = createServer(yoga)
 
-server.listen(4000)
+server.listen(4000, () => {
+  console.info('Server is running on http://localhost:4000/graphql')
+})
 ```
 
 ## Overview

examples/apollo-federation/gateway/index.js

@@ -14,7 +14,9 @@ async function main() {
 
   // Start the server and explore http://localhost:4000/graphql
   const server = createServer(yoga)
-  server.listen(4000)
+  server.listen(4000, () => {
+    console.info('Server is running on http://localhost:4000/graphql')
+  })
 }
 
 main().catch((err) => {

examples/bun/__integration-tests__/bun.spec.ts

@@ -1,65 +1,59 @@
-import { spawn } from 'child_process'
 import { fetch } from '@whatwg-node/fetch'
 
-describe('Bun integration', () => {
-  let bunProcess: ReturnType<typeof spawn>
-  let serverUrl: string
-
-  beforeAll(async () => {
-    // Start Bun
-    bunProcess = spawn('yarn', ['workspace', 'example-bun', 'start'])
+import { createYoga, createSchema } from 'graphql-yoga'
 
-    serverUrl = await new Promise((resolve, reject) => {
-      bunProcess.stderr?.on('data', (chunk) => {
-        const chunkString = chunk.toString('utf-8')
-        console.error(chunk.toString('utf-8'))
-        if (chunkString.includes('Command failed')) {
-          reject(new Error('Bun failed to start'))
-        }
-      })
+import { describe, it, expect } from 'bun:test'
 
-      bunProcess.stdout?.on('data', (chunk) => {
-        const chunkString = chunk.toString('utf-8')
-        console.log(chunk.toString('utf-8'))
-        if (chunkString.includes('Server is running on')) {
-          resolve(chunkString.split('Server is running on ')[1])
+describe('Bun integration', () => {
+  const yoga = createYoga({
+    schema: createSchema({
+      typeDefs: /* GraphQL */ `
+        type Query {
+          greetings: String
         }
-      })
-    })
-  })
-
-  afterAll(() => {
-    bunProcess.kill()
+      `,
+      resolvers: {
+        Query: {
+          greetings: () => 'Hello Bun!',
+        },
+      },
+    }),
   })
 
   it('shows GraphiQL', async () => {
-    const response = await fetch(serverUrl, {
-      method: 'GET',
-      headers: {
-        Accept: 'text/html',
+    const server = Bun.serve(yoga)
+    const response = await fetch(
+      new URL(yoga.graphqlEndpoint, server.hostname).toString(),
+      {
+        method: 'GET',
+        headers: {
+          Accept: 'text/html',
+        },
       },
-    })
-    expect(response.status).toEqual(200)
-    expect(response.headers.get('content-type')).toEqual('text/html')
+    )
+    expect(response.status).toBe(200)
+    expect(response.headers.get('content-type')).toBe('text/html')
     const htmlContents = await response.text()
-    expect(htmlContents).toContain('Yoga GraphiQL')
+    expect(htmlContents.includes('GraphiQL')).toBe(true)
+    server.stop()
   })
 
   it('accepts a query', async () => {
-    const response = await fetch(serverUrl, {
-      method: 'POST',
-      headers: {
-        'Content-Type': 'application/json',
+    const server = Bun.serve(yoga)
+    const response = await fetch(
+      new URL(yoga.graphqlEndpoint, server.hostname).toString(),
+      {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+        },
+        body: JSON.stringify({
+          query: `{ greetings }`,
+        }),
       },
-      body: JSON.stringify({
-        query: `{ greetings }`,
-      }),
-    })
+    )
     const result = await response.json()
-    expect(result).toEqual({
-      data: {
-        greetings: 'Hello Bun!',
-      },
-    })
+    expect(result.data.greetings).toBe('Hello Bun!')
+    server.stop()
   })
 })

examples/bun/package.json

@@ -4,7 +4,7 @@
   "license": "MIT",
   "scripts": {
     "start": "bun src/index.ts",
-    "check": "exit 0"
+    "check": "bun wiptest"
   },
   "dependencies": {
     "bun-types": "^0.1.5",

examples/bun/src/index.ts

@@ -1,4 +1,4 @@
-import { createYoga, createSchema, Repeater } from 'graphql-yoga'
+import { createYoga, createSchema } from 'graphql-yoga'
 
 const yoga = createYoga({
   schema: createSchema({

examples/bun/tsconfig.json

@@ -8,5 +8,5 @@
     // "bun-types" is the important part
     "types": ["bun-types"]
   },
-  "files": ["src/index.ts"]
+  "files": ["src/index.ts", "__integration-tests__/bun.spec.ts"]
 }