Use yoga with itty router

[lane711]

Hello, I have a pretty basic question. I am trying to get yoga working alongside itty-router. Something like:

import { Router } from "itty-router";
const router = Router();

declare const KVDATA: KVNamespace;

router.get("/", () => {
  return new Response(
    "Hello, world! This is the root page of your Worker template."
  );
});

// 404 for everything else
router.all("*", () => new Response("Not Found.", { status: 404 }));

const yoga = createYoga({
...
});




// attach the router "handle" to the event handler
addEventListener("fetch", (event) => 
   event.respondWith(router.handle(event.request))
);


 addEventListener('fetch', yoga)

but the yoga route of /graphql is throwing a 404

full code is here for ref:
https://github.com/lane711/yoga/blob/main/src/index.ts

[ardatan]

You can define Yoga as one of routes before 404 handler;
router.all('/graphql', yoga)
Because in your router above, you are attaching the router with 404 handler before Yoga

[lane711]

perfect, that works, thank you!

[lane711]

Now I am trying to do the same thing with hono instead of itty-router, but its throwing an error when I go to /graphql:

https://github.com/lane711/yoga/blob/feature/hono2/src/cms/graphql/graphql.ts
Trace: TypeError: Cannot read properties of undefined (reading 'endsWith')

import { createYoga, createSchema, Repeater } from "graphql-yoga";

export function setupGraphQl(app) {
  // app.all('/graphql', (c) => c.text('graph'))
  app.use("/graphql", graphql);

}

const graphql = createYoga({
  schema: createSchema({

[ardatan]

Are you sure app.use supported by Hono? Maybe it should be app.all.

[lane711]

It is, yes and I've tried both
https://hono.dev/api/hono

[yongyi520]

any updates on this? I encountered same issue adding graphql-yoga to hono, can't do it

[ardatan]

If you provide a reproducton, we'd love to help :)

[yongyi520]

thank you for the response, I checked out @lane711 discussion on other thread about hono and went with that!