DateTime, Date, Time, JSON - scalars proposal

[playerx]

What do you think to add those scalars out of the box:
DateTime, Date, Time, JSON

and make it configurable to disable them.

I think I will need them in all of my apps, especially DateTime.

If you think it's good idea I can send PR.

[schickling]

I think there's definitely value in supporting a common set of schema definitions + type resolvers as a standalone package (which then could be used by graphql-yoga).

I remember @RomanGotsiy and @IvanGoncharov coming up with the same idea. Would be great to hear their thoughts!

[IvanGoncharov]

We still have this idea and to release such package. However, it blocked by graphql/graphql-spec#326 since if you define custom scalars without specifying underlying serialization type you create a lot of problems for tooling and especially for code generation.

[playerx]

@IvanGoncharov as I guess its still a draft implementation and I think we can add those scalars today and describe serialization type for them when it will be possible and stable.

[kbrandwijk]

There's already graphql-iso-date for date scalars, and graphql-type-json for JSON types. I don't think we need to reinvent them again.

[playerx]

@kbrandwijk my proposal was just to use already implemented scalars and put the in graphql-yoga out of the box.

[kbrandwijk]

@playerx Yes, and I completely agree with that. My response was more for @IvanGoncharov who mentioned releasing another package like that.

[schickling]

This is also related to prisma-labs/prisma-binding#15

[IvanGoncharov]

@kbrandwijk In graphql-js 0.12.x you don't need to use any external package for JSON scalar since all scalars by default will accept all values:
https://github.com/graphql/graphql-js/blob/master/src/type/definition.js#L498
Just define it as scalar JSON inside your SDL schema 🎉

As for package I planning to do I have a few very specific features in mind not sure if it will work like intended but I will try 😄

[stale]

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.