enhance(config): remove extra usage_reporting.target_id validation (#669)

Validation for `usage_reporting`'s `target_id` is not needed since it is
already done by the SDK here;

https://github.com/graphql-hive/router/blob/main/lib/hive-console-sdk/src/agent/builder.rs#L166

Author: ardatan

.changeset/remove_extra_config_validation.md

@@ -0,0 +1,8 @@
+---
+router: patch
+config: patch
+---
+
+# Remove extra `target_id` validation in Router config
+
+This change removes the extra deserialization validation for the `target_id` field in the Router configuration, because it is already done by the Hive Console SDK.

Cargo.lock

@@ -23,7 +23,6 @@ http = { workspace = true }
 jsonwebtoken = { workspace = true }
 retry-policies = { workspace = true}
 tracing = { workspace = true }
-regex-automata = { workspace = true }
 
 schemars = "1.0.4"
 humantime-serde = "1.1.1"

lib/router-config/Cargo.toml

@@ -13,7 +13,6 @@ pub struct UsageReportingConfig {
     pub access_token: Option<String>,
 
     /// A target ID, this can either be a slug following the format “$organizationSlug/$projectSlug/$targetSlug” (e.g “the-guild/graphql-hive/staging”) or an UUID (e.g. “a0f4c605-6541-4350-8cfe-b31f21a4bf80”). To be used when the token is configured with an organization access token.
-    #[serde(deserialize_with = "deserialize_target_id")]
     pub target_id: Option<String>,
     /// For self-hosting, you can override `/usage` endpoint (defaults to `https://app.graphql-hive.com/usage`).
     #[serde(default = "default_endpoint")]
@@ -139,52 +138,6 @@ fn default_flush_interval() -> Duration {
     Duration::from_secs(5)
 }
 
-// Target ID regexp for validation: slug format
-const TARGET_ID_SLUG_REGEX: &str = r"^[a-zA-Z0-9-_]+\/[a-zA-Z0-9-_]+\/[a-zA-Z0-9-_]+$";
-// Target ID regexp for validation: UUID format
-const TARGET_ID_UUID_REGEX: &str =
-    r"^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$";
-
-fn deserialize_target_id<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>
-where
-    D: serde::Deserializer<'de>,
-{
-    let opt = Option::<String>::deserialize(deserializer)?;
-    if let Some(ref s) = opt {
-        let trimmed_s = s.trim();
-        if trimmed_s.is_empty() {
-            Ok(None)
-        } else {
-            let slug_regex =
-                regex_automata::meta::Regex::new(TARGET_ID_SLUG_REGEX).map_err(|err| {
-                    serde::de::Error::custom(format!(
-                        "Failed to compile target_id slug regex: {}",
-                        err
-                    ))
-                })?;
-            if slug_regex.is_match(trimmed_s) {
-                return Ok(Some(trimmed_s.to_string()));
-            }
-            let uuid_regex =
-                regex_automata::meta::Regex::new(TARGET_ID_UUID_REGEX).map_err(|err| {
-                    serde::de::Error::custom(format!(
-                        "Failed to compile target_id UUID regex: {}",
-                        err
-                    ))
-                })?;
-            if uuid_regex.is_match(trimmed_s) {
-                return Ok(Some(trimmed_s.to_string()));
-            }
-            Err(serde::de::Error::custom(format!(
-                "Invalid target_id format: '{}'. It must be either in slug format '$organizationSlug/$projectSlug/$targetSlug' or UUID format 'a0f4c605-6541-4350-8cfe-b31f21a4bf80'",
-                trimmed_s
-            )))
-        }
-    } else {
-        Ok(None)
-    }
-}
-
 #[derive(Debug, Clone, Copy)]
 pub struct Percentage {
     value: f64,