Tests

Author: ardatan

Cargo.lock

@@ -24,3 +24,7 @@ subgraphs = { path = "../bench/subgraphs" }
 
 mockito = "1.7.0"
 tempfile = "3.23.0"
+
+hmac = "0.12.1"
+sha2 = "0.10.9"
+hex = "0.4.3"

e2e/Cargo.toml

@@ -0,0 +1,3 @@
+hmac_signature:
+  enabled: true
+  secret: VERY_SECRET

e2e/configs/hmac_forward.router.yaml

@@ -0,0 +1,56 @@
+#[cfg(test)]
+mod hmac_e2e_tests {
+    use crate::testkit::{
+        init_graphql_request, init_router_from_config_file, wait_for_readiness, SubgraphsServer,
+    };
+
+    use ntex::web::test;
+    use sonic_rs::JsonValueTrait;
+
+    fn create_hmac_signature(secret: &str, query: &str) -> String {
+        use hex;
+        use hmac::{Hmac, Mac};
+        use sha2::Sha256;
+
+        type HmacSha256 = Hmac<Sha256>;
+
+        let mut mac =
+            HmacSha256::new_from_slice(secret.as_bytes()).expect("HMAC can take key of any size");
+        let message = format!("{{\"query\":\"{}\"}}", query);
+        mac.update(message.as_bytes());
+        let result = mac.finalize();
+        let code_bytes = result.into_bytes();
+        hex::encode(code_bytes)
+    }
+
+    #[ntex::test]
+    async fn should_forward_hmac_signature_to_subgraph_via_extensions() {
+        let subgraphs_server = SubgraphsServer::start().await;
+        let app = init_router_from_config_file("configs/hmac_forward.router.yaml")
+            .await
+            .unwrap();
+        wait_for_readiness(&app.app).await;
+        let query = "query{users{id}}";
+        let req = init_graphql_request(query, None);
+        let resp: ntex::web::WebResponse = test::call_service(&app.app, req.to_request()).await;
+
+        assert!(resp.status().is_success(), "Expected 200 OK");
+
+        let subgraph_requests = subgraphs_server
+            .get_subgraph_requests_log("accounts")
+            .await
+            .expect("expected requests sent to accounts subgraph");
+        assert_eq!(
+            subgraph_requests.len(),
+            1,
+            "expected 1 request to accounts subgraph"
+        );
+        let extensions = subgraph_requests[0].request_body.get("extensions").unwrap();
+
+        let expected_signature = create_hmac_signature("VERY_SECRET", query);
+        assert_eq!(
+            extensions.get("hmac_signature").unwrap(),
+            &expected_signature
+        );
+    }
+}

e2e/src/hmac.rs

@@ -3,6 +3,8 @@ mod file_supergraph;
 #[cfg(test)]
 mod hive_cdn_supergraph;
 #[cfg(test)]
+mod hmac;
+#[cfg(test)]
 mod jwt;
 #[cfg(test)]
 mod override_subgraph_urls;

e2e/src/lib.rs

@@ -186,25 +186,30 @@ impl HTTPSubgraphExecutor {
             None
         };
 
-        if let Some(extensions) = &execution_request.extensions {
-            let mut first = true;
-            if let Some(hmac_bytes) = hmac_signature_ext {
-                if first {
-                    body.put(FIRST_EXTENSION_STR);
-                    first = false;
-                } else {
-                    body.put(COMMA);
-                }
-                body.put(self.config.hmac_signature.extension_name.as_bytes());
-                let hmac_hex = hex::encode(hmac_bytes);
-                body.put(QUOTE);
-                body.put(hmac_hex.as_bytes());
-                body.put(QUOTE);
+        let mut first_extension = true;
+
+        if let Some(hmac_bytes) = hmac_signature_ext {
+            if first_extension {
+                body.put(FIRST_EXTENSION_STR);
+                first_extension = false;
+            } else {
+                body.put(COMMA);
             }
+            body.put(QUOTE);
+            body.put(self.config.hmac_signature.extension_name.as_bytes());
+            body.put(QUOTE);
+            body.put(COLON);
+            let hmac_hex = hex::encode(hmac_bytes);
+            body.put(QUOTE);
+            body.put(hmac_hex.as_bytes());
+            body.put(QUOTE);
+        }
+
+        if let Some(extensions) = &execution_request.extensions {
             for (extension_name, extension_value) in extensions {
-                if first {
+                if first_extension {
                     body.put(FIRST_EXTENSION_STR);
-                    first = false;
+                    first_extension = false;
                 } else {
                     body.put(COMMA);
                 }
@@ -222,8 +227,13 @@ impl HTTPSubgraphExecutor {
             }
         }
 
+        if !first_extension {
+            body.put(CLOSE_BRACE);
+        }
+
         body.put(CLOSE_BRACE);
 
+        println!("Built request body: {}", String::from_utf8_lossy(&body));
         Ok(body)
     }