Use constant for inflight link attribute

Author: kamilkisiela

lib/internal/src/telemetry/traces/spans/attributes.rs

@@ -43,6 +43,7 @@ pub const HIVE_ERROR_PATH: &str = "hive.error.path";
 /// Internal Hive attributes
 pub const HIVE_INFLIGHT_ROLE: &str = "hive.inflight.role";
 pub const HIVE_INFLIGHT_KEY: &str = "hive.inflight.key";
+pub const HIVE_INFLIGHT_LINK_RELATIONSHIP: &str = "hive.inflight.relationship";
 
 /// Generic/Common attributes
 pub const CACHE_HIT: &str = "cache.hit";

lib/internal/src/telemetry/traces/spans/http_request.rs

@@ -13,7 +13,11 @@ use tracing_opentelemetry::OpenTelemetrySpanExt;
 
 use crate::telemetry::traces::{
     disabled_span, is_tracing_enabled,
-    spans::{attributes, kind::HiveSpanKind, TARGET_NAME},
+    spans::{
+        attributes::{self, HIVE_INFLIGHT_LINK_RELATIONSHIP},
+        kind::HiveSpanKind,
+        TARGET_NAME,
+    },
 };
 
 pub struct HttpServerRequestSpan {
@@ -306,10 +310,10 @@ impl HttpInflightRequestSpan {
 
         self.span.add_link_with_attributes(
             leader_span_context.clone(),
-            vec![
-                KeyValue::new("link.type", "deduplication.waits_for"),
-                KeyValue::new("hive.inflight.relationship", "joiner_to_leader"),
-            ],
+            vec![KeyValue::new(
+                HIVE_INFLIGHT_LINK_RELATIONSHIP,
+                "joiner_to_leader",
+            )],
         );
     }