fix(ci): fail when audit tests failing (#495)

Federation audit tests are currently failing but CI workflow wasn't
failing.
So this makes CI workflow fail if some of audit test cases are failing.

The failing test cases fixed here;
#496

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Kamil Kisiela <[email protected]>

Author: 3 people

.github/workflows/ci.yaml

@@ -159,8 +159,8 @@ jobs:
           report_paths: "audits/reports/*.xml"
           group_reports: false
           annotate_only: true
-          fail_on_failure: true # do not fail the job if the report fails
-          fail_on_parse_error: true # do not fail the job if the report cannot be parsed
+          fail_on_failure: true
+          fail_on_parse_error: true
           job_summary: true
           verbose_summary: false
           skip_success_summary: true
@@ -211,8 +211,8 @@ jobs:
           job_name: federation-audit
           check_name: federation-audit
           check_title_template: "{{FILE_NAME}}"
-          fail_on_failure: false # do not fail the job if the report fails
-          fail_on_parse_error: false # do not fail the job if the report cannot be parsed
+          fail_on_failure: true
+          fail_on_parse_error: true
           annotate_only: true
           job_summary: true
           verbose_summary: false

lib/executor/src/response/graphql_error.rs

@@ -1,8 +1,8 @@
 use graphql_parser::Pos;
 use graphql_tools::validation::utils::ValidationError;
-use serde::{de, Deserialize, Deserializer, Serialize};
+use serde::{Deserialize, Serialize};
 use sonic_rs::Value;
-use std::{collections::HashMap, fmt};
+use std::collections::HashMap;
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 #[serde(rename_all = "camelCase")]
@@ -120,68 +120,16 @@ pub struct GraphQLErrorLocation {
     pub column: usize,
 }
 
-#[derive(Clone, Debug, Serialize, PartialEq)]
+#[derive(Clone, Debug, Deserialize, Serialize, PartialEq)]
+#[serde(untagged)]
 pub enum GraphQLErrorPathSegment {
     String(String),
     Index(usize),
 }
 
-impl<'de> Deserialize<'de> for GraphQLErrorPathSegment {
-    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-    where
-        D: Deserializer<'de>,
-    {
-        struct PathSegmentVisitor;
-
-        impl<'de> de::Visitor<'de> for PathSegmentVisitor {
-            type Value = GraphQLErrorPathSegment;
-
-            fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
-                formatter.write_str("a string or an integer for a GraphQL path segment")
-            }
-
-            fn visit_str<E>(self, value: &str) -> Result<Self::Value, E>
-            where
-                E: de::Error,
-            {
-                Ok(GraphQLErrorPathSegment::String(value.to_owned()))
-            }
-
-            fn visit_string<E>(self, value: String) -> Result<Self::Value, E>
-            where
-                E: de::Error,
-            {
-                Ok(GraphQLErrorPathSegment::String(value))
-            }
-
-            fn visit_u64<E>(self, value: u64) -> Result<Self::Value, E>
-            where
-                E: de::Error,
-            {
-                Ok(GraphQLErrorPathSegment::Index(value as usize))
-            }
-
-            fn visit_i64<E>(self, value: i64) -> Result<Self::Value, E>
-            where
-                E: de::Error,
-            {
-                if value < 0 {
-                    return Err(E::custom(format!(
-                        "path segment must be a non-negative integer, but got {}",
-                        value
-                    )));
-                }
-                Ok(GraphQLErrorPathSegment::Index(value as usize))
-            }
-        }
-
-        deserializer.deserialize_any(PathSegmentVisitor)
-    }
-}
-
-#[derive(Clone, Debug, Deserialize, Serialize, Default)]
+#[derive(Clone, Debug, Default, Deserialize, Serialize)]
+#[serde(transparent)]
 pub struct GraphQLErrorPath {
-    #[serde(flatten)]
     pub segments: Vec<GraphQLErrorPathSegment>,
 }