Skip to content

Cross-Origin Request Blocked => to fix it, I need to remove credentials in fetch call #127

@harobed

Description

@harobed

I use graphql-voyager in this Proof of Concept poc-postgraphile-forum.

I have my graphql server on http://127.0.0.1:5000/graphql (powered by postgraphile).

graphql-voyager is exposed on http://127.0.0.1:3001 and load graphql schema on http://127.0.0.1:5000/graphql.

Problem: I have this error in my browser:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://127.0.0.1:5000/graphql. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://127.0.0.1:5000/graphql. (Reason: CORS request did not succeed).
TypeError: NetworkError when attempting to fetch resource.

Capture d’écran 2019-07-27 à 09 25 42

To fix it, I need to remove credentials in fetch call, it is this line:

https://github.com/APIs-guru/graphql-voyager/blob/aea16b545e61c31a4de6cbbc833d94d596fb42db/src/middleware/render-voyager-page.ts#L53

At this time, I don't understand what is the credentials option aim.

Possible line of approach to fix it:

  1. remove credentials option if it is useless
  2. add graphql-voyager configuration option to enable / disable credentials option

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions