Skip to content

Commit 4ef394d

Browse files
committed
Modify tests with new variable_values and operation_name to remove warnings in tests
1 parent 7bf3638 commit 4ef394d

21 files changed

+202
-322
lines changed

docs/code_examples/console_async.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ async def get_continent_name(self, code):
3939

4040
assert self._session is not None
4141

42-
answer = await self._session.execute(
43-
self.get_continent_name_query
44-
)
42+
answer = await self._session.execute(self.get_continent_name_query)
4543

4644
return answer.get("continent").get("name") # type: ignore
4745

docs/code_examples/fastapi_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ async def get_continent(continent_code):
9393

9494
try:
9595
assert isinstance(client.session, ReconnectingAsyncClientSession)
96-
query.variable_values={"code": continent_code}
96+
query.variable_values = {"code": continent_code}
9797
result = await client.session.execute(query)
9898
except Exception as e:
9999
log.debug(f"get_continent Error: {e}")

tests/custom_scalars/test_datetime.py

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,11 @@ def test_shift_days():
117117

118118
query = gql("query shift5days($time: Datetime) {shiftDays(time: $time, days: 5)}")
119119

120-
variable_values = {
120+
query.variable_values = {
121121
"time": now,
122122
}
123123

124-
result = client.execute(query, variable_values=variable_values)
124+
result = client.execute(query)
125125

126126
print(result)
127127

@@ -151,11 +151,11 @@ def test_shift_days_serialized_manually_in_variables():
151151

152152
query = gql("query shift5days($time: Datetime) {shiftDays(time: $time, days: 5)}")
153153

154-
variable_values = {
154+
query.variable_values = {
155155
"time": "2021-11-12T11:58:13.461161",
156156
}
157157

158-
result = client.execute(query, variable_values=variable_values)
158+
result = client.execute(query)
159159

160160
print(result)
161161

@@ -171,13 +171,11 @@ def test_latest():
171171

172172
query = gql("query latest($times: [Datetime!]!) {latest(times: $times)}")
173173

174-
variable_values = {
174+
query.variable_values = {
175175
"times": [now, in_five_days],
176176
}
177177

178-
result = client.execute(
179-
query, variable_values=variable_values, serialize_variables=True
180-
)
178+
result = client.execute(query, serialize_variables=True)
181179

182180
print(result)
183181

@@ -194,11 +192,9 @@ def test_seconds():
194192
"query seconds($interval: IntervalInput) {seconds(interval: $interval)}"
195193
)
196194

197-
variable_values = {"interval": {"start": now, "end": in_five_days}}
195+
query.variable_values = {"interval": {"start": now, "end": in_five_days}}
198196

199-
result = client.execute(
200-
query, variable_values=variable_values, serialize_variables=True
201-
)
197+
result = client.execute(query, serialize_variables=True)
202198

203199
print(result)
204200

@@ -214,11 +210,9 @@ def test_seconds_omit_optional_start_argument():
214210
"query seconds($interval: IntervalInput) {seconds(interval: $interval)}"
215211
)
216212

217-
variable_values = {"interval": {"end": in_five_days}}
213+
query.variable_values = {"interval": {"end": in_five_days}}
218214

219-
result = client.execute(
220-
query, variable_values=variable_values, serialize_variables=True
221-
)
215+
result = client.execute(query, serialize_variables=True)
222216

223217
print(result)
224218

tests/custom_scalars/test_enum_colors.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ def test_opposite_color_variable_serialized_manually():
165165
}"""
166166
)
167167

168-
variable_values = {
168+
query.variable_values = {
169169
"color": "RED",
170170
}
171171

172-
result = client.execute(query, variable_values=variable_values)
172+
result = client.execute(query)
173173

174174
print(result)
175175

@@ -190,13 +190,11 @@ def test_opposite_color_variable_serialized_by_gql():
190190
}"""
191191
)
192192

193-
variable_values = {
193+
query.variable_values = {
194194
"color": RED,
195195
}
196196

197-
result = client.execute(
198-
query, variable_values=variable_values, serialize_variables=True
199-
)
197+
result = client.execute(query, serialize_variables=True)
200198

201199
print(result)
202200

@@ -328,13 +326,12 @@ def test_parse_results_with_operation_type():
328326
"""
329327
)
330328

331-
variable_values = {
329+
query.variable_values = {
332330
"color": "RED",
333331
}
332+
query.operation_name = "GetOppositeColor"
334333

335-
result = client.execute(
336-
query, variable_values=variable_values, operation_name="GetOppositeColor"
337-
)
334+
result = client.execute(query)
338335

339336
print(result)
340337

tests/custom_scalars/test_json.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,17 +166,15 @@ def test_json_value_input_in_ast_with_variables():
166166
}"""
167167
)
168168

169-
variable_values = {
169+
query.variable_values = {
170170
"name": "Barbara",
171171
"level": 1,
172172
"is_connected": False,
173173
"score": 69,
174174
"friends": ["Alex", "John"],
175175
}
176176

177-
result = client.execute(
178-
query, variable_values=variable_values, root_value=root_value
179-
)
177+
result = client.execute(query, root_value=root_value)
180178

181179
print(result)
182180

tests/custom_scalars/test_money.py

Lines changed: 32 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
)
2121
from graphql.utilities import value_from_ast_untyped
2222

23-
from gql import Client, GraphQLRequest, gql
23+
from gql import Client, gql
2424
from gql.transport.exceptions import TransportQueryError
2525
from gql.utilities import serialize_value, update_schema_scalar, update_schema_scalars
2626

@@ -275,11 +275,9 @@ def test_custom_scalar_in_input_variable_values():
275275

276276
money_value = {"amount": 10, "currency": "DM"}
277277

278-
variable_values = {"money": money_value}
278+
query.variable_values = {"money": money_value}
279279

280-
result = client.execute(
281-
query, variable_values=variable_values, root_value=root_value
282-
)
280+
result = client.execute(query, root_value=root_value)
283281

284282
assert result["toEuros"] == 5
285283

@@ -292,11 +290,10 @@ def test_custom_scalar_in_input_variable_values_serialized():
292290

293291
money_value = Money(10, "DM")
294292

295-
variable_values = {"money": money_value}
293+
query.variable_values = {"money": money_value}
296294

297295
result = client.execute(
298296
query,
299-
variable_values=variable_values,
300297
root_value=root_value,
301298
serialize_variables=True,
302299
)
@@ -312,14 +309,13 @@ def test_custom_scalar_in_input_variable_values_serialized_with_operation_name()
312309

313310
money_value = Money(10, "DM")
314311

315-
variable_values = {"money": money_value}
312+
query.variable_values = {"money": money_value}
313+
query.operation_name = "myquery"
316314

317315
result = client.execute(
318316
query,
319-
variable_values=variable_values,
320317
root_value=root_value,
321318
serialize_variables=True,
322-
operation_name="myquery",
323319
)
324320

325321
assert result["toEuros"] == 5
@@ -342,12 +338,11 @@ def test_serialize_variable_values_exception_multiple_ops_without_operation_name
342338

343339
money_value = Money(10, "DM")
344340

345-
variable_values = {"money": money_value}
341+
query.variable_values = {"money": money_value}
346342

347343
with pytest.raises(GraphQLError) as exc_info:
348344
client.execute(
349345
query,
350-
variable_values=variable_values,
351346
root_value=root_value,
352347
serialize_variables=True,
353348
)
@@ -374,15 +369,14 @@ def test_serialize_variable_values_exception_operation_name_not_found():
374369

375370
money_value = Money(10, "DM")
376371

377-
variable_values = {"money": money_value}
372+
query.variable_values = {"money": money_value}
373+
query.operation_name = "invalid_operation_name"
378374

379375
with pytest.raises(GraphQLError) as exc_info:
380376
client.execute(
381377
query,
382-
variable_values=variable_values,
383378
root_value=root_value,
384379
serialize_variables=True,
385-
operation_name="invalid_operation_name",
386380
)
387381

388382
exception = exc_info.value
@@ -398,13 +392,12 @@ def test_custom_scalar_subscribe_in_input_variable_values_serialized():
398392

399393
money_value = Money(10, "DM")
400394

401-
variable_values = {"money": money_value}
395+
query.variable_values = {"money": money_value}
402396

403397
expected_result = {"spend": Money(10, "DM")}
404398

405399
for result in client.subscribe(
406400
query,
407-
variable_values=variable_values,
408401
root_value=root_value,
409402
serialize_variables=True,
410403
parse_result=True,
@@ -544,9 +537,9 @@ async def test_custom_scalar_in_input_variable_values_with_transport(aiohttp_ser
544537
money_value = {"amount": 10, "currency": "DM"}
545538
# money_value = Money(10, "DM")
546539

547-
variable_values = {"money": money_value}
540+
query.variable_values = {"money": money_value}
548541

549-
result = await session.execute(query, variable_values=variable_values)
542+
result = await session.execute(query)
550543

551544
print(f"result = {result!r}")
552545
assert result["toEuros"] == 5
@@ -570,9 +563,9 @@ async def test_custom_scalar_in_input_variable_values_split_with_transport(
570563
}"""
571564
)
572565

573-
variable_values = {"amount": 10, "currency": "DM"}
566+
query.variable_values = {"amount": 10, "currency": "DM"}
574567

575-
result = await session.execute(query, variable_values=variable_values)
568+
result = await session.execute(query)
576569

577570
print(f"result = {result!r}")
578571
assert result["toEuros"] == 5
@@ -590,11 +583,9 @@ async def test_custom_scalar_serialize_variables(aiohttp_server):
590583

591584
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
592585

593-
variable_values = {"money": Money(10, "DM")}
586+
query.variable_values = {"money": Money(10, "DM")}
594587

595-
result = await session.execute(
596-
query, variable_values=variable_values, serialize_variables=True
597-
)
588+
result = await session.execute(query, serialize_variables=True)
598589

599590
print(f"result = {result!r}")
600591
assert result["toEuros"] == 5
@@ -611,12 +602,10 @@ async def test_custom_scalar_serialize_variables_no_schema(aiohttp_server):
611602

612603
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
613604

614-
variable_values = {"money": Money(10, "DM")}
605+
query.variable_values = {"money": Money(10, "DM")}
615606

616607
with pytest.raises(TransportQueryError):
617-
await session.execute(
618-
query, variable_values=variable_values, serialize_variables=True
619-
)
608+
await session.execute(query, serialize_variables=True)
620609

621610

622611
@pytest.mark.asyncio
@@ -643,11 +632,9 @@ async def test_custom_scalar_serialize_variables_schema_from_introspection(
643632

644633
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
645634

646-
variable_values = {"money": Money(10, "DM")}
635+
query.variable_values = {"money": Money(10, "DM")}
647636

648-
result = await session.execute(
649-
query, variable_values=variable_values, serialize_variables=True
650-
)
637+
result = await session.execute(query, serialize_variables=True)
651638

652639
print(f"result = {result!r}")
653640
assert result["toEuros"] == 5
@@ -667,11 +654,9 @@ async def test_update_schema_scalars(aiohttp_server):
667654

668655
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
669656

670-
variable_values = {"money": Money(10, "DM")}
657+
query.variable_values = {"money": Money(10, "DM")}
671658

672-
result = await session.execute(
673-
query, variable_values=variable_values, serialize_variables=True
674-
)
659+
result = await session.execute(query, serialize_variables=True)
675660

676661
print(f"result = {result!r}")
677662
assert result["toEuros"] == 5
@@ -743,11 +728,9 @@ def test_code():
743728

744729
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
745730

746-
variable_values = {"money": Money(10, "DM")}
731+
query.variable_values = {"money": Money(10, "DM")}
747732

748-
result = session.execute(
749-
query, variable_values=variable_values, serialize_variables=True
750-
)
733+
result = session.execute(query, serialize_variables=True)
751734

752735
print(f"result = {result!r}")
753736
assert result["toEuros"] == 5
@@ -765,14 +748,14 @@ async def test_custom_scalar_serialize_variables_sync_transport_2(
765748
def test_code():
766749
with Client(schema=schema, transport=transport, parse_results=True) as session:
767750

768-
query = "query myquery($money: Money) {toEuros(money: $money)}"
751+
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
769752

770-
variable_values = {"money": Money(10, "DM")}
753+
query.variable_values = {"money": Money(10, "DM")}
771754

772755
results = session.execute_batch(
773756
[
774-
GraphQLRequest(query, variable_values=variable_values),
775-
GraphQLRequest(query, variable_values=variable_values),
757+
query,
758+
query,
776759
],
777760
serialize_variables=True,
778761
)
@@ -793,14 +776,14 @@ async def test_custom_scalar_serialize_variables_async_transport(aiohttp_server)
793776
schema=schema, transport=transport, parse_results=True
794777
) as session:
795778

796-
query = "query myquery($money: Money) {toEuros(money: $money)}"
779+
query = gql("query myquery($money: Money) {toEuros(money: $money)}")
797780

798-
variable_values = {"money": Money(10, "DM")}
781+
query.variable_values = {"money": Money(10, "DM")}
799782

800783
results = await session.execute_batch(
801784
[
802-
GraphQLRequest(query, variable_values=variable_values),
803-
GraphQLRequest(query, variable_values=variable_values),
785+
query,
786+
query,
804787
],
805788
serialize_variables=True,
806789
)

0 commit comments

Comments
 (0)