Skip to content

Commit 66a1c3c

Browse files
authored
Bump graphql-core min version to 3.3.0a3 and remove await before subscribe (#417)
1 parent d140b83 commit 66a1c3c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

gql/transport/local_schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async def subscribe(
5959
The results are sent as an ExecutionResult object
6060
"""
6161

62-
subscribe_result = await subscribe(self.schema, document, *args, **kwargs)
62+
subscribe_result = subscribe(self.schema, document, *args, **kwargs)
6363

6464
if isinstance(subscribe_result, ExecutionResult):
6565
yield subscribe_result

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from setuptools import setup, find_packages
44

55
install_requires = [
6-
"graphql-core>=3.3.0a2,<3.4",
6+
"graphql-core>=3.3.0a3,<3.4",
77
"yarl>=1.6,<2.0",
88
"backoff>=1.11.1,<3.0",
99
]

tests/starwars/test_subscription.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ async def test_subscription_support():
3030
params = {"ep": "JEDI"}
3131
expected = [{**review, "episode": "JEDI"} for review in reviews[6]]
3232

33-
ai = await subscribe(StarWarsSchema, subs, variable_values=params)
33+
ai = subscribe(StarWarsSchema, subs, variable_values=params)
3434

3535
result = [result.data["reviewAdded"] async for result in ai]
3636

0 commit comments

Comments
 (0)