Skip to content

Commit 34f3c72

Browse files
committed
Updated middleware view management
1 parent 317c8ce commit 34f3c72

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

graphene_django/debug/tests/test_query.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ def resolve_reporter(self, *args, **kwargs):
5959
}]
6060
}
6161
}
62-
schema = graphene.Schema(query=Query, middlewares=[DjangoDebugMiddleware()])
63-
result = schema.execute(query, context_value=context())
62+
schema = graphene.Schema(query=Query)
63+
result = schema.execute(query, context_value=context(), middleware=[DjangoDebugMiddleware()])
6464
assert not result.errors
6565
assert result.data == expected
6666

@@ -108,8 +108,8 @@ def resolve_all_reporters(self, *args, **kwargs):
108108
}]
109109
}
110110
}
111-
schema = graphene.Schema(query=Query, middlewares=[DjangoDebugMiddleware()])
112-
result = schema.execute(query, context_value=context())
111+
schema = graphene.Schema(query=Query)
112+
result = schema.execute(query, context_value=context(), middleware=[DjangoDebugMiddleware()])
113113
assert not result.errors
114114
assert result.data == expected
115115

@@ -158,8 +158,8 @@ def resolve_all_reporters(self, *args, **kwargs):
158158
}]
159159
},
160160
}
161-
schema = graphene.Schema(query=Query, middlewares=[DjangoDebugMiddleware()])
162-
result = schema.execute(query, context_value=context())
161+
schema = graphene.Schema(query=Query)
162+
result = schema.execute(query, context_value=context(), middleware=[DjangoDebugMiddleware()])
163163
assert not result.errors
164164
assert result.data['allReporters'] == expected['allReporters']
165165
assert 'COUNT' in result.data['__debug']['sql'][0]['rawSql']
@@ -216,8 +216,8 @@ def resolve_all_reporters(self, *args, **kwargs):
216216
}]
217217
},
218218
}
219-
schema = graphene.Schema(query=Query, middlewares=[DjangoDebugMiddleware()])
220-
result = schema.execute(query, context_value=context())
219+
schema = graphene.Schema(query=Query)
220+
result = schema.execute(query, context_value=context(), middleware=[DjangoDebugMiddleware()])
221221
assert not result.errors
222222
assert result.data['allReporters'] == expected['allReporters']
223223
assert 'COUNT' in result.data['__debug']['sql'][0]['rawSql']

graphene_django/views.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from graphql.error import format_error as format_graphql_error
1515
from graphql.error import GraphQLError
1616
from graphql.execution import ExecutionResult
17-
from graphql.execution.middleware import MiddlewareManager
1817
from graphql.type.schema import GraphQLSchema
1918
from graphql.utils.get_operation_ast import get_operation_ast
2019

@@ -73,7 +72,7 @@ def __init__(self, schema=None, executor=None, middleware=None, root_value=None,
7372

7473
self.schema = schema
7574
if middleware is not None:
76-
self.middleware = MiddlewareManager(*list(instantiate_middleware(middleware)))
75+
self.middleware = list(instantiate_middleware(middleware))
7776
self.executor = executor
7877
self.root_value = root_value
7978
self.pretty = pretty
@@ -220,7 +219,7 @@ def execute_graphql_request(self, request, data, query, variables, operation_nam
220219
variable_values=variables,
221220
operation_name=operation_name,
222221
context_value=self.get_context(request),
223-
middlewares=self.get_middleware(request),
222+
middleware=self.get_middleware(request),
224223
executor=self.executor,
225224
)
226225
except Exception as e:

0 commit comments

Comments
 (0)