Skip to content

Commit 37848fa

Browse files
tcleonardThomas Leonard
andauthored
fix: convert Django BigIntegerField to BigInt GraphQL type (#1318)
Co-authored-by: Thomas Leonard <[email protected]>
1 parent 3473fe0 commit 37848fa

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

graphene_django/converter.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
Decimal,
2525
)
2626
from graphene.types.json import JSONString
27+
from graphene.types.scalars import BigInt
2728
from graphene.utils.str_converters import to_camel_case
2829
from graphql import GraphQLError, assert_valid_name
2930
from graphql.pyutils import register_description
@@ -186,10 +187,14 @@ def convert_field_to_uuid(field, registry=None):
186187
)
187188

188189

190+
@convert_django_field.register(models.BigIntegerField)
191+
def convert_big_int_field(field, registry=None):
192+
return BigInt(description=field.help_text, required=not field.null)
193+
194+
189195
@convert_django_field.register(models.PositiveIntegerField)
190196
@convert_django_field.register(models.PositiveSmallIntegerField)
191197
@convert_django_field.register(models.SmallIntegerField)
192-
@convert_django_field.register(models.BigIntegerField)
193198
@convert_django_field.register(models.IntegerField)
194199
def convert_field_to_int(field, registry=None):
195200
return Int(description=get_django_field_description(field), required=not field.null)

graphene_django/tests/test_converter.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from graphene.relay import ConnectionField, Node
1111
from graphene.types.datetime import Date, DateTime, Time
1212
from graphene.types.json import JSONString
13+
from graphene.types.scalars import BigInt
1314

1415
from ..compat import (
1516
ArrayField,
@@ -140,8 +141,8 @@ def test_should_small_integer_convert_int():
140141
assert_conversion(models.SmallIntegerField, graphene.Int)
141142

142143

143-
def test_should_big_integer_convert_int():
144-
assert_conversion(models.BigIntegerField, graphene.Int)
144+
def test_should_big_integer_convert_big_int():
145+
assert_conversion(models.BigIntegerField, BigInt)
145146

146147

147148
def test_should_integer_convert_int():

0 commit comments

Comments
 (0)