Merge branch 'feat-retrieving-queried-fields-only' into feat-pagination-performance

Author: arunsureshkumar

graphene_mongo/fields.py

@@ -119,6 +119,9 @@ def is_filterable(k):
                     ),
             ):
                 return False
+            if getattr(converted, "type", None) and getattr(converted.type, "_of_type", None) and issubclass(
+                    (get_type(converted.type.of_type)), graphene.Union):
+                return False
             if isinstance(converted, (graphene.List)) and issubclass(
                     getattr(converted, "_of_type", None), graphene.Union
             ):

graphene_mongo/tests/models.py

@@ -84,7 +84,7 @@ class Reporter(mongoengine.Document):
         mongoengine.EmbeddedDocumentField(EmbeddedArticle)
     )
     embedded_list_articles = mongoengine.EmbeddedDocumentListField(EmbeddedArticle)
-    generic_reference = mongoengine.GenericReferenceField(choices=[Article, Editor])
+    generic_reference = mongoengine.GenericReferenceField(choices=[Article, Editor],required=True)
     generic_embedded_document = mongoengine.GenericEmbeddedDocumentField(
         choices=[EmbeddedArticle, EmbeddedFoo]
     )

graphene_mongo/tests/test_converter.py

@@ -352,8 +352,12 @@ class Meta:
         Reporter._fields["generic_reference"], registry.get_global_registry()
     )
     assert isinstance(generic_reference_field, graphene.Field)
-    assert isinstance(generic_reference_field.type(), graphene.Union)
-    assert generic_reference_field.type()._meta.types == (A, E)
+    if not Reporter._fields["generic_reference"].required:
+        assert isinstance(generic_reference_field.type(), graphene.Union)
+        assert generic_reference_field.type()._meta.types == (A, E)
+    else:
+        assert issubclass(generic_reference_field.type.of_type, graphene.Union)
+        assert generic_reference_field.type.of_type._meta.types == (A, E)
 
 
 def test_should_generic_embedded_document_convert_union():