Merge pull request #33 from graphql-python/feat-embedded-doc

Test: EmbeddedDocument field

Author: abawchen

graphene_mongo/tests/fixtures.py

@@ -1,6 +1,6 @@
 from .models import (
     Article, Editor, EmbeddedArticle, Player,
-    Reporter, Child
+    Reporter, Child, ProfessorMetadata, ProfessorVector,
 )
 
 
@@ -84,3 +84,16 @@ def setup_fixtures():
 
     child2 = Child(bar='bar', baz='baz')
     child2.save()
+
+    ProfessorVector.drop_collection()
+    professor_metadata = ProfessorMetadata(
+        id='5e06aa20-6805-4eef-a144-5615dedbe32b',
+        first_name='Steven',
+        last_name='Curry',
+        departments=['NBA', 'MLB']
+    )
+    professor_vector = ProfessorVector(
+        vec=[1.0, 2.3],
+        metadata=professor_metadata
+    )
+    professor_vector.save()

graphene_mongo/tests/models.py

@@ -4,7 +4,7 @@
 )
 from mongoengine.fields import (
     DateTimeField, EmailField, EmbeddedDocumentField,
-    EmbeddedDocumentListField, ListField,
+    FloatField, EmbeddedDocumentListField, ListField,
     MapField, ReferenceField, StringField
 )
 
@@ -59,6 +59,8 @@ class Reporter(Document):
 
 
 class Player(Document):
+
+    meta = {'collection': 'test_player'}
     first_name = StringField(required=True)
     last_name = StringField(required=True)
     opponent = ReferenceField('Player')
@@ -78,5 +80,21 @@ class Parent(Document):
 
 class Child(Parent):
 
-    meta = {'collection': 'Child'}
+    meta = {'collection': 'test_child'}
     baz = StringField()
+
+
+class ProfessorMetadata(EmbeddedDocument):
+
+    meta = {'collection': 'test_professor_metadata'}
+    id = StringField(primary_key=False)
+    first_name = StringField()
+    last_name = StringField()
+    departments = ListField(StringField())
+
+
+class ProfessorVector(Document):
+
+    meta = {'collection': 'test_professor_vector'}
+    vec = ListField(FloatField())
+    metadata = EmbeddedDocumentField(ProfessorMetadata)

graphene_mongo/tests/test_converter.py

@@ -6,8 +6,10 @@
 
 from py.test import raises
 
-from .models import Article, Editor, EmbeddedArticle, Player, Reporter
-
+from .models import (
+    Article, Editor, EmbeddedArticle, Player, Reporter,
+    ProfessorMetadata, ProfessorVector,
+)
 from .. import registry
 from ..converter import convert_mongoengine_field
 from ..fields import MongoengineConnectionField
@@ -80,7 +82,7 @@ def test_should_field_convert_list():
     assert_conversion(mongoengine.ListField, graphene.List, field=mongoengine.StringField())
 
 
-def test_should_embedded_convert_dynamic():
+def test_should_reference_convert_dynamic():
 
     class E(MongoengineObjectType):
 
@@ -96,6 +98,22 @@ class Meta:
     assert graphene_type.type == E
 
 
+def test_should_embedded_convert_dynamic():
+
+    class PM(MongoengineObjectType):
+
+        class Meta:
+            model = ProfessorMetadata
+            interfaces = (Node,)
+
+    dynamic_field = convert_mongoengine_field(
+        ProfessorVector._fields['metadata'], PM._meta.registry)
+    assert isinstance(dynamic_field, Dynamic)
+    graphene_type = dynamic_field.get_type()
+    assert isinstance(graphene_type, graphene.Field)
+    assert graphene_type.type == PM
+
+
 def test_should_convert_none():
     registry.reset_global_registry()
     dynamic_field = convert_mongoengine_field(

graphene_mongo/tests/test_query.py

@@ -3,10 +3,12 @@
 import graphene
 
 from .fixtures import setup_fixtures
-from .models import Editor, Player, Reporter
-from .types import (EditorType,
-                    PlayerType,
-                    ReporterType)
+from .models import (
+    Editor, Player, Reporter, ProfessorVector
+)
+from .types import (
+    EditorType, PlayerType, ReporterType, ProfessorVectorType
+)
 
 setup_fixtures()
 
@@ -227,6 +229,34 @@ def resolve_all_players(self, *args, **kwargs):
     assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)
 
 
-# TODO:
-def test_should_paging():
-    pass
+def test_should_query_with_embedded_document():
+
+    class Query(graphene.ObjectType):
+        professor_vector = graphene.Field(ProfessorVectorType, id=graphene.String())
+
+        def resolve_professor_vector(self, info, id):
+            return ProfessorVector.objects(metadata__id=id).first()
+
+    query = """
+        query {
+          professorVector(id: "5e06aa20-6805-4eef-a144-5615dedbe32b") {
+            vec
+            metadata {
+                firstName
+            }
+          }
+        }
+    """
+
+    expected = {
+        'professorVector': {
+            'vec': [1.0, 2.3],
+            'metadata': {
+                'firstName': 'Steven'
+            }
+        }
+    }
+    schema = graphene.Schema(query=Query, types=[ProfessorVectorType])
+    result = schema.execute(query)
+    assert not result.errors
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)

graphene_mongo/tests/types.py

@@ -3,7 +3,7 @@
 from ..types import MongoengineObjectType
 from .models import (
     Article, Editor, EmbeddedArticle, Player, Reporter,
-    Parent, Child
+    Parent, Child, ProfessorMetadata, ProfessorVector,
 )
 
 
@@ -49,6 +49,18 @@ class Meta:
         model = Child
 
 
+class ProfessorMetadataType(MongoengineObjectType):
+
+    class Meta:
+        model = ProfessorMetadata
+
+
+class ProfessorVectorType(MongoengineObjectType):
+
+    class Meta:
+        model = ProfessorVector
+
+
 class ArticleNode(MongoengineObjectType):
 
     class Meta: