test: Make test_query.test_should_node pass.

Author: abawchen

graphene_mongoengine/converter.py

@@ -1,5 +1,5 @@
 from graphene import (ID, Boolean, Dynamic, Enum, Field, Float, Int, List,
-                      NonNull, String, UUID)
+                      NonNull, String, UUID, is_node)
 from graphene.types.datetime import DateTime, Time
 from graphene.types.json import JSONString
 from graphene.utils.str_converters import to_camel_case, to_const
@@ -65,7 +65,9 @@ def convert_postgres_array_to_list(field, registry=None):
     base_type = convert_mongoengine_field(field.field, registry=registry)
     if isinstance(base_type, (Dynamic)):
         base_type = base_type.get_type()._type
-    if not isinstance(base_type, (List, NonNull)) \
+    if is_node(base_type):
+       return MongoengineConnectionField(base_type)
+    elif not isinstance(base_type, (List, NonNull)) \
         and not isinstance(field.field, mongoengine.ReferenceField):
         base_type = type(base_type)
     return List(base_type, description=field.db_field, required=not field.null)

graphene_mongoengine/fields.py

@@ -29,13 +29,12 @@ def get_resolver(self, parent_resolver):
 
 class MongoengineConnectionField(ConnectionField):
 
-    '''
-    def __init__(self, *args, **kwargs):
-        super(MongoengineConnectionField, self).__init(
+    def __init__(self, type, *args, **kwargs):
+        super(MongoengineConnectionField, self).__init__(
+            type,
             *args,
             **kwargs
         )
-    '''
 
     @property
     def type(self):
@@ -62,7 +61,7 @@ def merge_querysets(cls, default_queryset, queryset):
         return queryset & default_queryset
 
     """
-    TODO: Not sure this works well or not
+    TODO: Not sure this works :(
     """
     @classmethod
     def connection_resolver(cls, resolver, connection, model, root, info, **args):
@@ -85,5 +84,6 @@ def connection_resolver(cls, resolver, connection, model, root, info, **args):
         return connection
 
     def get_resolver(self, parent_resolver):
+        ('??')
         return partial(self.connection_resolver, parent_resolver, self.type, self.model)
 

graphene_mongoengine/tests/test_converter.py

@@ -92,7 +92,6 @@ def test_should_one2many_convert_list():
     class A(MongoengineObjectType):
         class Meta:
             model = Article
-            interfaces = (Node,)
 
     graphene_field = convert_mongoengine_field(
         Reporter._fields['articles'], A._meta.registry)

graphene_mongoengine/tests/test_query.py

@@ -119,3 +119,64 @@ def resolve_reporter(self, *args, **kwargs):
     assert not result.errors
     assert dict(result.data['reporter']) == expected['reporter']
 
+def test_should_node():
+    class ArticleNode(MongoengineObjectType):
+        class Meta:
+            model = Article
+            interfaces = (Node,)
+
+    class ReporterNode(MongoengineObjectType):
+        class Meta:
+            model = Reporter
+            interfaces = (Node,)
+
+    class Query(graphene.ObjectType):
+        node = Node.Field()
+        reporter = graphene.Field(ReporterNode)
+
+        def resolve_reporter(self, *args, **kwargs):
+            return Reporter.objects.first()
+
+    query = '''
+        query ReporterQuery {
+            reporter {
+                firstName,
+                articles {
+                    edges {
+                        node {
+                            headline
+                        }
+                    }
+                }
+                lastName,
+                email
+            }
+        }
+    '''
+    expected = {
+        'reporter': {
+            'firstName': 'Allen',
+            'lastName': 'Iverson',
+            'articles': {
+                'edges': [
+                    {
+                        'node': {
+                            'headline': 'Hello'
+                        }
+                    },
+                    {
+                        'node': {
+                            'headline': 'World'
+                        }
+                    }
+                ],
+            },
+            'email': '[email protected]'
+        }
+    }
+
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+    assert not result.errors
+    assert dict(result.data['reporter']) == expected['reporter']
+

graphene_mongoengine/types.py

@@ -79,7 +79,6 @@ def __init_subclass_with_meta__(cls, model=None, registry=None, skip_registry=Fa
         _meta.registry = registry
         _meta.fields = mongoengine_fields
         _meta.connection = connection
-
         super(MongoengineObjectType, cls).__init_subclass_with_meta__(
             _meta=_meta, interfaces=interfaces, **options
         )
@@ -101,13 +100,13 @@ def is_type_of(cls, root, info):
     def get_node(cls, id, context, info):
         if isinstance(getattr(cls._meta.model, get_key_name(cls._meta.model)), NumberAttribute):
             return cls._meta.model.get(int(id))
-        else:
-            return cls._meta.model.get(id)
+
+        return cls._meta.model.get(id)
 
     def resolve_id(self, info):
         return str(self.id)
 
-    @classmethod
-    def get_connection(cls):
-        return connection_for_type(cls)
+    #@classmethod
+    #def get_connection(cls):
+    #    return connection_for_type(cls)