Skip to content

Commit 3b7874b

Browse files
committed
minor: Simplify code
1 parent 6bc60fd commit 3b7874b

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

graphene_mongo/tests/test_fields.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,29 @@
66
def test_article_field_args():
77
field = MongoengineConnectionField(nodes.ArticleNode)
88

9-
field_args = ['id', 'headline', 'pub_date']
10-
assert set(field.field_args.keys()) == set(field_args)
9+
field_args = {'id', 'headline', 'pub_date'}
10+
assert set(field.field_args.keys()) == field_args
1111

12-
reference_args = ['editor', 'reporter']
13-
assert set(field.reference_args.keys()) == set(reference_args)
12+
reference_args = {'editor', 'reporter'}
13+
assert set(field.reference_args.keys()) == reference_args
1414

15-
default_args = ['after', 'last', 'first', 'before']
16-
args = field_args + reference_args + default_args
17-
assert set(field.args) == set(args)
15+
default_args = {'after', 'last', 'first', 'before'}
16+
args = field_args | reference_args | default_args
17+
assert set(field.args) == args
1818

1919

2020
def test_reporter_field_args():
2121
field = MongoengineConnectionField(nodes.ReporterNode)
2222

23-
field_args = ['id', 'first_name', 'last_name', 'email', 'awards']
24-
assert set(field.field_args.keys()) == set(field_args)
23+
field_args = {'id', 'first_name', 'last_name', 'email', 'awards'}
24+
assert set(field.field_args.keys()) == field_args
25+
26+
27+
def test_editor_field_args():
28+
field = MongoengineConnectionField(nodes.EditorNode)
29+
30+
field_args = {'id', 'first_name', 'last_name', 'metadata'}
31+
assert set(field.field_args.keys()) == field_args
2532

2633

2734
def test_field_args_with_property():

0 commit comments

Comments
 (0)