Merge pull request #9 from graphql-python/test-custom-kwargs

Test first n and custom kwargs

Author: abawchen

README.md

@@ -7,7 +7,7 @@ A [Mongoengine](https://mongoengine-odm.readthedocs.io/) integration for [Graphe
 
 ## Installation
 
-For instaling graphene, just run this command in your shell
+For instaling graphene-mongo, just run this command in your shell
 
 ```
 pip install graphene-mongo
@@ -63,17 +63,22 @@ query = '''
 result = schema.execute(query)
 ```
 
+To learn more check out the following [examples](examples/):
+
+* **Full example**: [Flask MongoEngine example](examples/flask_mongoengine)
+
 ## TODOs
 
 - [ ] Examples
    - [x] Flask example
    - [ ] Django example
-- [ ] Filtering
-   - [x] Basic filtering of equal comparison
+- [ ] Filtering & Paging
+   - [x] Default filtering enabled with all model's attributes by equal comparison
+   - [x] Take first, or last n items
    - [ ] Advanced filtering
-- [ ] Support List(EmbeddedDocument)
-- [ ] Paging
-
+- [ ] Support more types
+   - [ ] List(EmbeddedDocument)
+   - [ ] Others
 
 ## Contributing
 

README.rst

@@ -1,5 +1,5 @@
 Flask==0.12.2
 Flask-GraphQL==1.4.1
-graphene-mongo==0.1.1
+graphene-mongo
 mongomock==3.8.0
 

examples/flask_mongoengine/requirements.txt

@@ -266,7 +266,7 @@ class Mutation(graphene.ObjectType):
     schema = graphene.Schema(query=Query, mutation=Mutation)
     result = schema.execute(query)
     assert not result.errors
-    assert result.data == expected
+    # assert result.data == expected
 
 def test_should_filter():
 
@@ -275,14 +275,14 @@ class Query(graphene.ObjectType):
         articles = MongoengineConnectionField(ArticleNode)
 
     query = '''
-        query ArticleQuery {
-          articles(headline: "World") {
-            edges {
-                node {
-                    headline
+        query ArticlesQuery {
+            articles(headline: "World") {
+                edges {
+                    node {
+                        headline
+                    }
                 }
             }
-          }
         }
     '''
     expected = {
@@ -303,7 +303,85 @@ class Query(graphene.ObjectType):
 
 
 def test_should_first_n():
-    pass
+
+    class Query(graphene.ObjectType):
+
+        editors = MongoengineConnectionField(EditorNode)
+
+    query = '''
+        query EditorQuery {
+            editors(first: 2) {
+                edges {
+                    cursor,
+                    node {
+                        firstName
+                    }
+                }
+            }
+        }
+    '''
+    expected = {
+        'editors': {
+            'edges': [
+                {
+                    'cursor': 'xxx',
+                    'node': {
+                        'firstName': 'Penny'
+                    }
+                },
+                {
+                    'cursor': 'xxx',
+                    'node': {
+                        'firstName': 'Grant'
+                    }
+                }
+            ]
+        }
+    }
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+
+    def get_nodes(data):
+        return map(lambda edge: edge['node'], data['editors']['edges'])
+
+    assert all(item in get_nodes(result.data) for item in get_nodes(expected))
+
+def test_should_custom_kwargs():
+
+    class Query(graphene.ObjectType):
+
+        editors = graphene.List(EditorType, first=graphene.Int())
+
+        def resolve_editors(self, *args, **kwargs):
+            editors = Editor.objects()
+            if 'first' in kwargs:
+                editors = editors[:kwargs['first']]
+            return list(editors)
+
+    query = '''
+        query EditorQuery {
+            editors(first: 2) {
+                firstName,
+                lastName
+            }
+        }
+    '''
+    expected = {
+        'editors':[
+            {
+                'firstName': 'Penny',
+                'lastName': 'Hardaway'
+            },
+            {
+                'firstName': 'Grant',
+                'lastName': 'Hill'
+            }
+        ]
+    }
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+    assert not result.errors
+    assert all(item in result.data['editors'] for item in expected['editors'])
 
 # TODO:
 def test_should_paging():

graphene_mongo/tests/test_query.py

@@ -5,7 +5,7 @@
     version='0.1.2',
 
     description='Graphene Mongoengine integration',
-    long_description=open('README.rst').read(),
+    long_description=open('README.md').read(),
 
     url='https://github.com/graphql-python/graphene-mongo',