Skip to content

Commit 43b3907

Browse files
committed
style: Import mongoengine instead of detail fields
1 parent f6a60e2 commit 43b3907

File tree

4 files changed

+77
-72
lines changed

4 files changed

+77
-72
lines changed

graphene_mongo/converter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ def convert_field_to_list(field, registry=None):
111111

112112

113113
@convert_mongoengine_field.register(mongoengine.EmbeddedDocumentField)
114+
@convert_mongoengine_field.register(mongoengine.GenericReferenceField)
114115
@convert_mongoengine_field.register(mongoengine.ReferenceField)
115116
def convert_field_to_dynamic(field, registry=None):
116117
model = field.document_type

graphene_mongo/tests/models.py

Lines changed: 69 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
1+
import mongoengine
12
from datetime import datetime
2-
from mongoengine import (
3-
connect, Document, EmbeddedDocument
4-
)
53
from mongoengine.fields import (
64
DateTimeField, EmailField, EmbeddedDocumentField,
75
FloatField, EmbeddedDocumentListField, ListField, LazyReferenceField,
86
MapField, MultiPolygonField, PointField, PolygonField,
97
ReferenceField, StringField,
108
)
119

12-
connect('graphene-mongo-test', host='mongomock://localhost', alias='default')
10+
mongoengine.connect('graphene-mongo-test', host='mongomock://localhost', alias='default')
1311

1412

15-
class Publisher(Document):
13+
class Publisher(mongoengine.Document):
1614

1715
meta = {'collection': 'test_publisher'}
18-
name = StringField()
16+
name = mongoengine.StringField()
1917

2018
@property
2119
def legal_name(self):
@@ -25,42 +23,44 @@ def bad_field(self):
2523
return None
2624

2725

28-
class Editor(Document):
26+
class Editor(mongoengine.Document):
2927
"""
3028
An Editor of a publication.
3129
"""
3230

3331
meta = {'collection': 'test_editor'}
34-
id = StringField(primary_key=True)
35-
first_name = StringField(required=True, help_text="Editor's first name.", db_field='fname')
36-
last_name = StringField(required=True, help_text="Editor's last name.")
37-
metadata = MapField(field=StringField(), help_text="Arbitrary metadata.")
38-
company = LazyReferenceField(Publisher)
32+
id = mongoengine.StringField(primary_key=True)
33+
first_name = mongoengine.StringField(required=True, help_text="Editor's first name.", db_field='fname')
34+
last_name = mongoengine.StringField(required=True, help_text="Editor's last name.")
35+
metadata = mongoengine.MapField(field=mongoengine.StringField(), help_text="Arbitrary metadata.")
36+
company = mongoengine.LazyReferenceField(Publisher)
3937

4038

41-
class Article(Document):
39+
class Article(mongoengine.Document):
4240

4341
meta = {'collection': 'test_article'}
44-
headline = StringField(required=True, help_text="The article headline.")
45-
pub_date = DateTimeField(default=datetime.now,
46-
verbose_name="publication date",
47-
help_text="The date of first press.")
48-
editor = ReferenceField(Editor)
49-
reporter = ReferenceField('Reporter')
42+
headline = mongoengine.StringField(required=True, help_text="The article headline.")
43+
pub_date = mongoengine.DateTimeField(
44+
default=datetime.now,
45+
verbose_name="publication date",
46+
help_text="The date of first press.")
47+
editor = mongoengine.ReferenceField(Editor)
48+
reporter = mongoengine.ReferenceField('Reporter')
5049

5150

52-
class EmbeddedArticle(EmbeddedDocument):
51+
class EmbeddedArticle(mongoengine.EmbeddedDocument):
5352

5453
meta = {'collection': 'test_embedded_article'}
55-
headline = StringField(required=True)
56-
pub_date = DateTimeField(default=datetime.now)
57-
editor = ReferenceField(Editor)
58-
reporter = ReferenceField('Reporter')
54+
headline = mongoengine.StringField(required=True)
55+
pub_date = mongoengine.DateTimeField(default=datetime.now)
56+
editor = mongoengine.ReferenceField(Editor)
57+
reporter = mongoengine.ReferenceField('Reporter')
5958

6059

61-
class Reporter(Document):
60+
class Reporter(mongoengine.Document):
6261

6362
meta = {'collection': 'test_reporter'}
63+
<<<<<<< HEAD
6464
id = StringField(primary_key=True)
6565
first_name = StringField(required=True)
6666
last_name = StringField(required=True)
@@ -69,30 +69,39 @@ class Reporter(Document):
6969
articles = ListField(ReferenceField(Article))
7070
embedded_articles = ListField(EmbeddedDocumentField(EmbeddedArticle))
7171
embedded_list_articles = EmbeddedDocumentListField(EmbeddedArticle)
72+
id = StringField(primary_key=True)
73+
first_name = StringField(required=True)
74+
last_name = StringField(required=True)
75+
email = EmailField()
76+
articles = ListField(ReferenceField(Article))
77+
embedded_articles = ListField(EmbeddedDocumentField(EmbeddedArticle))
78+
embedded_list_articles = EmbeddedDocumentListField(EmbeddedArticle)
79+
awards = ListField(StringField())
7280

7381

74-
class Player(Document):
82+
class Player(mongoengine.Document):
7583

7684
meta = {'collection': 'test_player'}
77-
first_name = StringField(required=True)
78-
last_name = StringField(required=True)
79-
opponent = ReferenceField('Player')
80-
players = ListField(ReferenceField('Player'))
81-
articles = ListField(ReferenceField('Article'))
82-
embedded_list_articles = EmbeddedDocumentListField(EmbeddedArticle)
85+
first_name = mongoengine.StringField(required=True)
86+
last_name = mongoengine.StringField(required=True)
87+
opponent = mongoengine.ReferenceField('Player')
88+
players = mongoengine.ListField(mongoengine.ReferenceField('Player'))
89+
articles = mongoengine.ListField(mongoengine.ReferenceField('Article'))
90+
embedded_list_articles = mongoengine.EmbeddedDocumentListField(EmbeddedArticle)
8391

8492

85-
class Parent(Document):
93+
class Parent(mongoengine.Document):
8694

8795
meta = {
8896
'collection': 'test_parent',
8997
'allow_inheritance': True
9098
}
91-
bar = StringField()
92-
loc = MultiPolygonField()
99+
bar = mongoengine.StringField()
100+
loc = mongoengine.MultiPolygonField()
101+
# reference = GenericReferenceField()
93102

94103

95-
class CellTower(Document):
104+
class CellTower(mongoengine.Document):
96105

97106
meta = {
98107
'collection': 'test_cell_tower',
@@ -105,49 +114,51 @@ class CellTower(Document):
105114
class Child(Parent):
106115

107116
meta = {'collection': 'test_child'}
108-
baz = StringField()
109-
loc = PointField()
117+
baz = mongoengine.StringField()
118+
loc = mongoengine.PointField()
110119

111120

112-
class ProfessorMetadata(EmbeddedDocument):
121+
class ProfessorMetadata(mongoengine.EmbeddedDocument):
113122

114123
meta = {'collection': 'test_professor_metadata'}
115-
id = StringField(primary_key=False)
116-
first_name = StringField()
117-
last_name = StringField()
118-
departments = ListField(StringField())
124+
id = mongoengine.StringField(primary_key=False)
125+
first_name = mongoengine.StringField()
126+
last_name = mongoengine.StringField()
127+
departments = mongoengine.ListField(mongoengine.StringField())
119128

120129

121-
class ProfessorVector(Document):
130+
class ProfessorVector(mongoengine.Document):
122131

123132
meta = {'collection': 'test_professor_vector'}
124-
vec = ListField(FloatField())
125-
metadata = EmbeddedDocumentField(ProfessorMetadata)
133+
vec = mongoengine.ListField(mongoengine.FloatField())
134+
metadata = mongoengine.EmbeddedDocumentField(ProfessorMetadata)
126135

127136

128-
class ParentWithRelationship(Document):
137+
class ParentWithRelationship(mongoengine.Document):
129138

130139
meta = {'collection': 'test_parent_reference'}
131-
before_child = ListField(ReferenceField("ChildRegisteredBefore"))
132-
after_child = ListField(ReferenceField("ChildRegisteredAfter"))
133-
name = StringField()
140+
before_child = mongoengine.ListField(
141+
mongoengine.ReferenceField('ChildRegisteredBefore'))
142+
after_child = mongoengine.ListField(
143+
mongoengine.ReferenceField('ChildRegisteredAfter'))
144+
name = mongoengine.StringField()
134145

135146

136-
class ChildRegisteredBefore(Document):
147+
class ChildRegisteredBefore(mongoengine.Document):
137148

138149
meta = {'collection': 'test_child_before_reference'}
139-
parent = ReferenceField(ParentWithRelationship)
140-
name = StringField()
150+
parent = mongoengine.ReferenceField(ParentWithRelationship)
151+
name = mongoengine.StringField()
141152

142153

143-
class ChildRegisteredAfter(Document):
154+
class ChildRegisteredAfter(mongoengine.Document):
144155

145156
meta = {'collection': 'test_child_after_reference'}
146-
parent = ReferenceField(ParentWithRelationship)
147-
name = StringField()
157+
parent = mongoengine.ReferenceField(ParentWithRelationship)
158+
name = mongoengine.StringField()
148159

149160

150-
class ErroneousModel(Document):
161+
class ErroneousModel(mongoengine.Document):
151162
meta = {'collection': 'test_colliding_objects_model'}
152163

153-
objects = ListField(StringField())
164+
objects = mongoengine.ListField(mongoengine.StringField())

graphene_mongo/tests/test_relay_query.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -779,16 +779,16 @@ class Query(graphene.ObjectType):
779779

780780
query = '''
781781
query {
782-
allProfessors {
783-
edges {
784-
node {
785-
vec,
786-
metadata {
787-
firstName
782+
allProfessors {
783+
edges {
784+
node {
785+
vec,
786+
metadata {
787+
firstName
788+
}
788789
}
789790
}
790791
}
791-
}
792792
}
793793
'''
794794
expected = {

setup.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,10 @@
77
description='Graphene Mongoengine integration',
88
long_description=open('README.rst').read(),
99
# long_description_content_type='text/markdown',
10-
1110
url='https://github.com/graphql-python/graphene-mongo',
12-
1311
author='Abaw Chen',
1412
author_email='[email protected]',
15-
1613
license='MIT',
17-
1814
classifiers=[
1915
'Development Status :: 3 - Alpha',
2016
'Intended Audience :: Developers',
@@ -25,11 +21,8 @@
2521
'Programming Language :: Python :: 3.6',
2622
'Programming Language :: Python :: Implementation :: PyPy',
2723
],
28-
2924
keywords='api graphql protocol rest relay graphene mongo mongoengine',
30-
3125
packages=find_packages(exclude=['tests']),
32-
3326
install_requires=[
3427
'graphene>=2.1.3,<3',
3528
'mongoengine>=0.15.0',

0 commit comments

Comments
 (0)