style: Introduce flake8 and make it pass.

Author: abawchen

Makefile

@@ -8,7 +8,10 @@ clean:
 	@find . -name "*.pyc" -delete
 	@find . -name "__pycache__" -delete
 
-test: clean
+lint:
+	@flake8 graphene_mongo
+
+test: clean lint
 	py.test --cov=graphene_mongo
 
 register-pypitest:

graphene_mongo/__init__.py

@@ -9,6 +9,6 @@
 
 __all__ = [
     '__version__',
-    'MongoengineObjectType'
+    'MongoengineObjectType',
+    'MongoengineConnectionField'
 ]
-

graphene_mongo/converter.py

@@ -1,9 +1,6 @@
-from graphene import (ID, Boolean, Dynamic, Enum, Field, Float, Int, List,
-                      NonNull, String, UUID, is_node)
-from graphene.types.datetime import DateTime, Time
+from graphene import (ID, Boolean, Dynamic, Field, Float, Int, List,
+                      NonNull, String, is_node)
 from graphene.types.json import JSONString
-from graphene.utils.str_converters import to_camel_case, to_const
-from graphql import assert_valid_name
 
 import mongoengine
 
@@ -66,9 +63,9 @@ def convert_postgres_array_to_list(field, registry=None):
     if isinstance(base_type, (Dynamic)):
         base_type = base_type.get_type()._type
     if is_node(base_type):
-       return MongoengineConnectionField(base_type)
+        return MongoengineConnectionField(base_type)
     elif not isinstance(base_type, (List, NonNull)) \
-        and not isinstance(field.field, mongoengine.ReferenceField):
+            and not isinstance(field.field, mongoengine.ReferenceField):
         base_type = type(base_type)
     return List(base_type, description=field.db_field, required=not field.null)
 
@@ -86,4 +83,3 @@ def dynamic_type():
         return Field(_type)
 
     return Dynamic(dynamic_type)
-

graphene_mongo/fields.py

@@ -3,15 +3,14 @@
 from collections import OrderedDict
 from functools import partial, reduce
 
-from graphene import Field
+from graphene import Field, List
 from graphene.relay import ConnectionField
 from graphene.relay.connection import PageInfo
 from graphql_relay.connection.arrayconnection import connection_from_list_slice
 from graphene.types.argument import to_arguments
 
-from .utils import maybe_queryset
-
 
+# noqa
 class MongoengineListField(Field):
 
     def __init__(self, _type, *args, **kwargs):
@@ -21,9 +20,9 @@ def __init__(self, _type, *args, **kwargs):
     def model(self):
         return self.type.of_type._meta.node._meta.model
 
-    @staticmethod
-    def list_resolver(resolver, root, info, **args):
-        return maybe_queryset(resolver(root, info, **args))
+    # @staticmethod
+    # def list_resolver(resolver, root, info, **args):
+    #    return maybe_queryset(resolver(root, info, **args))
 
     def get_resolver(self, parent_resolver):
         return partial(self.list_resolver, parent_resolver)
@@ -115,4 +114,3 @@ def connection_resolver(cls, resolver, connection, model, root, info, **args):
 
     def get_resolver(self, parent_resolver):
         return partial(self.connection_resolver, parent_resolver, self.type, self.model)
-

graphene_mongo/registry.py

@@ -28,4 +28,3 @@ def get_global_registry():
 def reset_global_registry():
     global registry
     registry = None
-

graphene_mongo/tests/test_query.py

@@ -308,4 +308,3 @@ def test_should_first_n():
 # TODO:
 def test_should_paging():
     pass
-

graphene_mongo/types.py

@@ -1,6 +1,6 @@
 from collections import OrderedDict
 
-from graphene import Field, ObjectType
+from graphene import Field
 from graphene.relay import Connection, Node
 from graphene.types.objecttype import ObjectType, ObjectTypeOptions
 from graphene.types.utils import yank_fields_from_attrs
@@ -35,6 +35,7 @@ class MongoengineObjectTypeOptions(ObjectTypeOptions):
     connection = None  # type: Type[Connection]
     filter_fields = ()
 
+
 class MongoengineObjectType(ObjectType):
 
     @classmethod
@@ -97,17 +98,14 @@ def is_type_of(cls, root, info):
             ).format(root))
         return isinstance(root, cls._meta.model)
 
+    # noqa
     @classmethod
     def get_node(cls, id, context, info):
-        if isinstance(getattr(cls._meta.model, get_key_name(cls._meta.model)), NumberAttribute):
-            return cls._meta.model.get(int(id))
-
         return cls._meta.model.get(id)
 
     def resolve_id(self, info):
         return str(self.id)
 
-    #@classmethod
-    #def get_connection(cls):
-    #    return connection_for_type(cls)
-
+    # @classmethod
+    # def get_connection(cls):
+    #     return connection_for_type(cls)

graphene_mongo/utils.py

@@ -25,12 +25,6 @@ def is_valid_mongoengine_model(model):
     )
 
 
-def maybe_queryset(value):
-    if isinstance(value, Manager):
-        value = value.get_queryset()
-    return value
-
-
 def import_single_dispatch():
     try:
         from functools import singledispatch
@@ -54,11 +48,11 @@ def import_single_dispatch():
     return singledispatch
 
 
+# noqa
 def get_type_for_document(schema, document):
     types = schema.types.values()
     for _type in types:
         type_document = hasattr(_type, '_meta') and getattr(
             _type._meta, 'document', None)
         if document == type_document:
             return _type
-

setup.cfg

@@ -3,7 +3,7 @@ description-file = README.md
 
 [flake8]
 exclude = setup.py,docs/*,examples/*,tests
-max-line-length = 120
+max-line-length = 130
 
 [coverage:run]
 omit = */tests/*