feat: Use uuid as part of union name as a work-around

Author: abawchen

graphene_mongo/converter.py

@@ -1,4 +1,5 @@
 import mongoengine
+import uuid
 from graphene import (
     ID,
     Boolean,
@@ -23,8 +24,6 @@
 
 singledispatch = import_single_dispatch()
 
-_union_registry = {}
-
 
 class MongoEngineConversionError(Exception):
     pass
@@ -126,18 +125,21 @@ def convert_field_to_union(field, registry=None):
         if _type:
             _types.append(_type.type)
         else:
-            # Can register type auto-matically here.
+            # TODO: Register type auto-matically here.
             pass
 
     if len(_types) == 0:
         return None
 
-    print('*' * 50)
-    print(field.__dict__)
-    name = field._owner_document.__name__ + '_' + field.db_field + '_union'
+    # XXX: Use uuid to avoid duplicate name
+    name = '{}_{}_union_{}'.format(
+        field._owner_document.__name__,
+        field.db_field,
+        str(uuid.uuid1()).replace('-', '')
+    )
     Meta = type('Meta', (object, ), {'types': tuple(_types)})
-    _union_registry[name] = type(name, (Union, ), {'Meta': Meta})
-    return Field(_union_registry.get(name))
+    _union = type(name, (Union, ), {'Meta': Meta})
+    return Field(_union)
 
 
 @convert_mongoengine_field.register(mongoengine.EmbeddedDocumentField)

graphene_mongo/tests/nodes.py

@@ -1,7 +1,8 @@
 import graphene
 from graphene.relay import Node
 
-from . import models, types
+from . import models
+from . import types  # noqa: F401
 from ..types import MongoengineObjectType
 
 

graphene_mongo/types.py

@@ -2,7 +2,7 @@
 import mongoengine
 
 from collections import OrderedDict
-from graphene.relay import Connection, Node, is_node
+from graphene.relay import Connection, Node
 from graphene.types.objecttype import ObjectType, ObjectTypeOptions
 from graphene.types.utils import yank_fields_from_attrs
 
@@ -13,6 +13,17 @@
 
 
 def construct_fields(model, registry, only_fields, exclude_fields):
+    """
+    Args:
+        model (mongoengine.Document):
+        registry (graphene_mongo.registry.Registry):
+        only_fields ([str]):
+        exclude_fields ([str]):
+
+    Returns:
+        (OrderedDict, OrderedDict): coverted fields and self reference fields.
+
+    """
     _model_fields = get_model_fields(model)
     fields = OrderedDict()
     self_referenced = OrderedDict()