Merge pull request #23 from alqmy/master

feat: Added tests for last n and actually fixed it.

Author: abawchen

graphene_mongo/fields.py

@@ -122,7 +122,7 @@ def get_query(cls, model, info, **args):
                 objs = objs[:first]
             if last is not None:
                 # fix for https://github.com/graphql-python/graphene-mongo/issues/20
-                objs = objs[-last:]
+                objs = objs[-(last+1):]
 
         return objs
 

graphene_mongo/tests/test_relay_query.py

@@ -223,11 +223,9 @@ def mutate(self, info, headline):
 
             return CreateArticle(article=article)
 
-
     class Query(graphene.ObjectType):
         node = Node.Field()
 
-
     class Mutation(graphene.ObjectType):
 
         create_article = CreateArticle.Field()
@@ -255,6 +253,7 @@ class Mutation(graphene.ObjectType):
     assert not result.errors
     assert result.data == expected
 
+
 def test_should_filter():
 
     class Query(graphene.ObjectType):
@@ -361,7 +360,8 @@ class Query(graphene.ObjectType):
     result = schema.execute(query)
 
     assert not result.errors
-    assert all(item in get_nodes(result.data, 'editors') for item in get_nodes(expected, 'editors'))
+    assert all(item in get_nodes(result.data, 'editors')
+               for item in get_nodes(expected, 'editors'))
 
 
 def test_should_after():
@@ -403,7 +403,8 @@ class Query(graphene.ObjectType):
     result = schema.execute(query)
 
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(
+        expected, sort_keys=True)
 
 
 def test_should_before():
@@ -445,7 +446,51 @@ class Query(graphene.ObjectType):
     result = schema.execute(query)
 
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(
+        expected, sort_keys=True)
+
+
+def test_should_last_n():
+    class Query(graphene.ObjectType):
+        players = MongoengineConnectionField(PlayerNode)
+
+    query = '''
+        query EditorQuery {
+            players(last: 2) {
+                edges {
+                    cursor,
+                    node {
+                        firstName
+                    }
+                }
+            }
+        }
+    '''
+    expected = {
+        'players': {
+            'edges': [
+                {
+                    'cursor': 'YXJyYXljb25uZWN0aW9uOjE=',
+                    'node': {
+                        'firstName': 'Magic',
+                    }
+                },
+                {
+                    'cursor': 'YXJyYXljb25uZWN0aW9uOjI=',
+                    'node': {
+                        'firstName': 'Larry',
+                    }
+                }
+            ]
+        }
+    }
+    schema = graphene.Schema(query=Query)
+    result = schema.execute(query)
+
+    assert not result.errors
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(
+        expected, sort_keys=True)
+
 
 def test_should_self_reference():
 
@@ -511,7 +556,7 @@ class Query(graphene.ObjectType):
                             ]
                         },
                         'embeddedListArticles': {
-                             'edges': []
+                            'edges': []
                         }
 
                     }
@@ -544,7 +589,8 @@ class Query(graphene.ObjectType):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)
+    assert json.dumps(result.data, sort_keys=True) == json.dumps(
+        expected, sort_keys=True)
 
 
 # TODO: