feat: Take care list of EmbeddedDocument.

Author: abawchen

graphene_mongo/converter.py

@@ -60,13 +60,22 @@ def convert_date_to_string(field, registry=None):
 @convert_mongoengine_field.register(mongoengine.ListField)
 def convert_field_to_list(field, registry=None):
     base_type = convert_mongoengine_field(field.field, registry=registry)
+
     if isinstance(base_type, (Dynamic)):
-        base_type = base_type.get_type()._type
+        base_type = base_type.get_type()
+        if base_type is None:
+            return
+        base_type = base_type._type
+
     if is_node(base_type):
         return MongoengineConnectionField(base_type)
-    elif not isinstance(base_type, (List, NonNull)) \
-            and not isinstance(field.field, mongoengine.ReferenceField):
+
+    # Non-relationship field
+    relations = (mongoengine.ReferenceField, mongoengine.EmbeddedDocumentField)
+    if not isinstance(base_type, (List, NonNull)) \
+            and not isinstance(field.field, relations):
         base_type = type(base_type)
+
     return List(base_type, description=field.db_field, required=not field.null)
 
 

graphene_mongo/tests/models.py

@@ -49,8 +49,7 @@ class Reporter(Document):
     last_name = StringField(required=True)
     email = EmailField()
     articles = ListField(ReferenceField(Article))
-    # FIXME
-    # embedded_articles = ListField(EmbeddedDocumentField(EmbeddedArticle))
+    embedded_articles = ListField(EmbeddedDocumentField(EmbeddedArticle))
     # FIXME
     # custom_map = MapField(field=StringField())
     awards = ListField(StringField())

graphene_mongo/tests/test_converter.py

@@ -75,7 +75,7 @@ def test_should_field_convert_list():
     assert_conversion(mongoengine.ListField, graphene.List, field=mongoengine.StringField())
 
 
-def test_should_reference_convert_dynamic():
+def test_should_embedded_convert_dynamic():
 
     class E(MongoengineObjectType):
 
@@ -90,7 +90,7 @@ class Meta:
     assert graphene_type.type == E
 
 
-def test_should_one2many_convert_list():
+def test_should_list_of_reference_convert_list():
 
     class A(MongoengineObjectType):
 
@@ -102,8 +102,21 @@ class Meta:
     dynamic_field = graphene_field.get_type()
     assert dynamic_field._of_type == A
 
+
+def test_should_list_of_embedded_convert_list():
+
+    class E(MongoengineObjectType):
+
+        class Meta:
+            model = EmbeddedArticle
+
+    graphene_field = convert_mongoengine_field(Reporter._fields['embedded_articles'], E._meta.registry)
+    assert isinstance(graphene_field, graphene.List)
+    dynamic_field = graphene_field.get_type()
+    assert dynamic_field._of_type == E
+
+
 def test_should_self_reference_convert_dynamic():
-    # pass
     class P(MongoengineObjectType):
 
         class Meta: