Merge pull request #85 from riverfr0zen/master

Let MongoengineObjectType subclasses pass their own _meta

Author: abawchen

graphene_mongo/tests/test_types.py

@@ -4,7 +4,7 @@
 from graphene.relay import Node, is_node
 
 from .. import registry
-from ..types import MongoengineObjectType
+from ..types import MongoengineObjectType, MongoengineObjectTypeOptions
 from .models import Article, EmbeddedArticle, Reporter
 from .models import Parent, Child
 from .utils import with_local_registry
@@ -127,3 +127,41 @@ class Meta:
             exclude_fields = ('headline')
 
     assert 'headline' not in list(A._meta.fields.keys())
+
+
+@with_local_registry
+def test_passing_meta_when_subclassing_mongoengine_objecttype():
+    class TypeSubclassWithBadOptions(MongoengineObjectType):
+        class Meta:
+            abstract = True
+
+        @classmethod
+        def __init_subclass_with_meta__(cls, **kwargs):
+            _meta = ['hi']
+            super(TypeSubclassWithBadOptions, cls). \
+                __init_subclass_with_meta__(_meta=_meta, **kwargs)
+
+    with raises(Exception) as einfo:
+        class A(TypeSubclassWithBadOptions):
+            class Meta:
+                model = Article
+    assert 'instance of MongoengineObjectTypeOptions' in str(einfo.value)
+
+    class TypeSubclass(MongoengineObjectType):
+        class Meta:
+            abstract = True
+
+        @classmethod
+        def __init_subclass_with_meta__(cls, some_subclass_attr=None,
+                                        **kwargs):
+            _meta = MongoengineObjectTypeOptions(cls)
+            _meta.some_subclass_attr = some_subclass_attr
+            super(TypeSubclass, cls). \
+                __init_subclass_with_meta__(_meta=_meta, **kwargs)
+
+    class B(TypeSubclass):
+        class Meta:
+            model = Article
+            some_subclass_attr = 'someval'
+    assert hasattr(B._meta, 'some_subclass_attr')
+    assert B._meta.some_subclass_attr == 'someval'

graphene_mongo/types.py

@@ -75,7 +75,8 @@ class MongoengineObjectType(ObjectType):
     def __init_subclass_with_meta__(cls, model=None, registry=None, skip_registry=False,
                                     only_fields=(), exclude_fields=(), filter_fields=None,
                                     connection=None, connection_class=None, use_connection=None,
-                                    connection_field_class=None, interfaces=(), **options):
+                                    connection_field_class=None, interfaces=(),
+                                    _meta=None, **options):
 
         assert is_valid_mongoengine_model(model), (
             'The attribute model in {}.Meta must be a valid Mongoengine Model. '
@@ -118,7 +119,14 @@ def __init_subclass_with_meta__(cls, model=None, registry=None, skip_registry=Fa
         else:
             connection_field_class = MongoengineConnectionField
 
-        _meta = MongoengineObjectTypeOptions(cls)
+        if _meta:
+            assert isinstance(_meta, MongoengineObjectTypeOptions), (
+                '_meta must be an instance of MongoengineObjectTypeOptions, '
+                'received {}'
+            ).format(_meta.__class__)
+        else:
+            _meta = MongoengineObjectTypeOptions(cls)
+
         _meta.model = model
         _meta.registry = registry
         _meta.fields = mongoengine_fields