Skip to content

Commit 0996935

Browse files
author
markus
committed
Added tests.
1 parent c01a9b1 commit 0996935

File tree

2 files changed

+41
-3
lines changed

2 files changed

+41
-3
lines changed

graphene/relay/node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def id_resolver(parent_resolver, node, root, args, context, info, parent_type_na
4747
return node.to_global_id(parent_type_name, type_id) # root._meta.name
4848

4949
def get_resolver(self, parent_resolver):
50-
return partial(self.id_resolver, parent_resolver, self.node, parent_type_name=self._parent_type_name)
50+
return partial(self.id_resolver, parent_resolver, self.node, parent_type_name=self.parent_type_name)
5151

5252

5353
class NodeMeta(InterfaceMeta):

graphene/relay/tests/test_global_id.py

Lines changed: 40 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
from ..node import Node, GlobalID
1+
from graphql_relay import to_global_id
22

3-
from ...types import NonNull, ID
3+
from ..node import Node, GlobalID
4+
from ...types import NonNull, ID, ObjectType, String
5+
from ...types.definitions import GrapheneObjectType
46

57

68
class CustomNode(Node):
@@ -9,6 +11,26 @@ class Meta:
911
name = 'Node'
1012

1113

14+
class User(ObjectType):
15+
16+
class Meta:
17+
interfaces = [CustomNode]
18+
name = String()
19+
20+
21+
class Info(object):
22+
23+
def __init__(self, parent_type):
24+
self.parent_type = GrapheneObjectType(
25+
graphene_type=parent_type,
26+
name=parent_type._meta.name,
27+
description=parent_type._meta.description,
28+
fields=None,
29+
is_type_of=parent_type.is_type_of,
30+
interfaces=None
31+
)
32+
33+
1234
def test_global_id_defaults_to_required_and_node():
1335
gid = GlobalID()
1436
assert isinstance(gid.type, NonNull)
@@ -20,3 +42,19 @@ def test_global_id_allows_overriding_of_node_and_required():
2042
gid = GlobalID(node=CustomNode, required=False)
2143
assert gid.type == ID
2244
assert gid.node == CustomNode
45+
46+
47+
def test_global_id_defaults_to_info_parent_type():
48+
my_id = '1'
49+
gid = GlobalID()
50+
id_resolver = gid.get_resolver(lambda *_: my_id)
51+
my_global_id = id_resolver(None, None, None, Info(User))
52+
assert my_global_id == to_global_id(User._meta.name, my_id)
53+
54+
55+
def test_global_id_allows_setting_customer_parent_type():
56+
my_id = '1'
57+
gid = GlobalID(parent_type=User)
58+
id_resolver = gid.get_resolver(lambda *_: my_id)
59+
my_global_id = id_resolver(None, None, None, None)
60+
assert my_global_id == to_global_id(User._meta.name, my_id)

0 commit comments

Comments
 (0)