Skip to content

Commit 34d6d07

Browse files
committed
Improved tests
1 parent 83589a2 commit 34d6d07

File tree

4 files changed

+15
-26
lines changed

4 files changed

+15
-26
lines changed

graphene/contrib/django/tests/data.py

Lines changed: 0 additions & 19 deletions
This file was deleted.

graphene/contrib/django/tests/test_types.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from mock import patch
2+
13
from graphql.core.type import GraphQLInterfaceType, GraphQLObjectType
24

35
from graphene import Schema
@@ -24,9 +26,6 @@ class Human(DjangoNode):
2426

2527
pub_date = Int()
2628

27-
def get_node(self, id):
28-
pass
29-
3029
class Meta:
3130
model = Article
3231

@@ -35,6 +34,12 @@ def test_django_interface():
3534
assert DjangoNode._meta.is_interface is True
3635

3736

37+
@patch('graphene.contrib.django.tests.models.Article.objects.filter')
38+
def test_django_get_node(objects):
39+
Human.get_node(1)
40+
objects.assert_called_with(id=1)
41+
42+
3843
def test_pseudo_interface_registered():
3944
object_type = schema.T(Character)
4045
assert Character._meta.is_interface is True

graphene/core/types/field.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ def contribute_to_class(self, cls, attname):
5151
def resolver(self):
5252
return self.resolver_fn or self.get_resolver_fn()
5353

54-
@resolver.setter
55-
def resolver(self, value):
56-
self.resolver_fn = value
57-
5854
def get_resolver_fn(self):
5955
resolve_fn_name = 'resolve_%s' % self.attname
6056
if hasattr(self.object_type, resolve_fn_name):

graphene/core/types/tests/test_field.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,13 @@ class MyObjectType(ObjectType):
6666
assert schema.T(field).type == schema.T(MyObjectType)
6767

6868

69+
def test_field_eq():
70+
field = Field('self', name='my_customName')
71+
field2 = Field('self', name='my_customName')
72+
assert field == field
73+
assert field2 != field
74+
75+
6976
def test_field_mounted():
7077
field = Field(List('MyObjectType'), name='my_customName')
7178

0 commit comments

Comments
 (0)