Skip to content

Commit 7e901f8

Browse files
committed
Improved test coverage
1 parent eff882e commit 7e901f8

File tree

3 files changed

+70
-42
lines changed

3 files changed

+70
-42
lines changed

graphene/utils/resolver_from_annotations.py

Lines changed: 0 additions & 39 deletions
This file was deleted.
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
import pytest
2+
from .. import deprecated
3+
from ..deprecated import deprecated as deprecated_decorator, warn_deprecation
4+
5+
6+
def test_warn_deprecation(mocker):
7+
mocker.patch.object(deprecated.warnings, 'warn')
8+
9+
warn_deprecation("OH!")
10+
deprecated.warnings.warn.assert_called_with('OH!', stacklevel=2, category=DeprecationWarning)
11+
12+
13+
def test_deprecated_decorator(mocker):
14+
mocker.patch.object(deprecated, 'warn_deprecation')
15+
16+
@deprecated_decorator
17+
def my_func():
18+
return True
19+
20+
result = my_func()
21+
assert result
22+
deprecated.warn_deprecation.assert_called_with("Call to deprecated function my_func.")
23+
24+
25+
def test_deprecated_class(mocker):
26+
mocker.patch.object(deprecated, 'warn_deprecation')
27+
28+
@deprecated_decorator
29+
class X:
30+
pass
31+
32+
result = X()
33+
assert result
34+
deprecated.warn_deprecation.assert_called_with("Call to deprecated class X.")
35+
36+
37+
def test_deprecated_decorator_text(mocker):
38+
mocker.patch.object(deprecated, 'warn_deprecation')
39+
40+
@deprecated_decorator("Deprecation text")
41+
def my_func():
42+
return True
43+
44+
result = my_func()
45+
assert result
46+
deprecated.warn_deprecation.assert_called_with("Call to deprecated function my_func (Deprecation text).")
47+
48+
49+
def test_deprecated_class_text(mocker):
50+
mocker.patch.object(deprecated, 'warn_deprecation')
51+
52+
@deprecated_decorator("Deprecation text")
53+
class X:
54+
pass
55+
56+
result = X()
57+
assert result
58+
deprecated.warn_deprecation.assert_called_with("Call to deprecated class X (Deprecation text).")
59+
60+
61+
def test_deprecated_other_object(mocker):
62+
mocker.patch.object(deprecated, 'warn_deprecation')
63+
64+
with pytest.raises(TypeError) as exc_info:
65+
deprecated_decorator({})

graphene/utils/tests/test_resolve_only_args.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44

55
def test_resolve_only_args(mocker):
66
mocker.patch.object(deprecated, 'warn_deprecation')
7-
def resolver(*args, **kwargs):
8-
return kwargs
7+
def resolver(root, **args):
8+
return root, args
99

1010
my_data = {'one': 1, 'two': 2}
1111

12-
wrapped = resolve_only_args(resolver)
12+
wrapped_resolver = resolve_only_args(resolver)
1313
assert deprecated.warn_deprecation.called
14+
result = wrapped_resolver(1, 2, a=3)
15+
assert result == (1, {'a': 3})

0 commit comments

Comments
 (0)