Merge pull request #342 from ekampf/feature/connection_edges_should_be_nonnull

Connection Edges should be NonNull

Author: syrusakbary

examples/starwars_relay/tests/test_objectidentification.py

@@ -56,7 +56,7 @@ def test_str_schema():
 
 type ShipConnection {
   pageInfo: PageInfo!
-  edges: [ShipEdge]
+  edges: [ShipEdge]!
 }
 
 type ShipEdge {

graphene/relay/connection.py

@@ -82,7 +82,7 @@ class EdgeBase(AbstractType):
 
         class ConnectionBase(AbstractType):
             page_info = Field(PageInfo, name='pageInfo', required=True)
-            edges = List(edge)
+            edges = NonNull(List(edge))
 
         bases = (ConnectionBase, ) + bases
         attrs = dict(attrs, _meta=options, Edge=edge)

graphene/relay/tests/test_connection.py

@@ -28,8 +28,9 @@ class Edge:
     pageinfo_field = fields['page_info']
 
     assert isinstance(edge_field, Field)
-    assert isinstance(edge_field.type, List)
-    assert edge_field.type.of_type == MyObjectConnection.Edge
+    assert isinstance(edge_field.type, NonNull)
+    assert isinstance(edge_field.type.of_type, List)
+    assert edge_field.type.of_type.of_type == MyObjectConnection.Edge
 
     assert isinstance(pageinfo_field, Field)
     assert isinstance(pageinfo_field.type, NonNull)