Skip to content

Commit a0fc843

Browse files
authored
Merge pull request #641 from presencelearning/issue-610-connection-name
Allow ObjectType to set Connection name
2 parents 8123c4a + a2178dc commit a0fc843

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

graphene/relay/connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class EdgeBase(object):
7373
edge = type(edge_name, edge_bases, {})
7474
cls.Edge = edge
7575

76-
_meta.name = name
76+
options['name'] = name
7777
_meta.node = node
7878
_meta.fields = OrderedDict([
7979
('page_info', Field(PageInfo, name='pageInfo', required=True)),

graphene/relay/tests/test_connection.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,21 @@ class Meta:
5252
assert list(fields.keys()) == ['page_info', 'edges', 'extra']
5353

5454

55+
def test_connection_name():
56+
custom_name = "MyObjectCustomNameConnection"
57+
58+
class BaseConnection(object):
59+
extra = String()
60+
61+
class MyObjectConnection(BaseConnection, Connection):
62+
63+
class Meta:
64+
node = MyObject
65+
name = custom_name
66+
67+
assert MyObjectConnection._meta.name == custom_name
68+
69+
5570
def test_edge():
5671
class MyObjectConnection(Connection):
5772

@@ -122,9 +137,10 @@ def test_connectionfield_node_deprecated():
122137
field = ConnectionField(MyObject)
123138
with pytest.raises(Exception) as exc_info:
124139
field.type
125-
140+
126141
assert "ConnectionField's now need a explicit ConnectionType for Nodes." in str(exc_info.value)
127142

143+
128144
def test_connectionfield_custom_args():
129145
class MyObjectConnection(Connection):
130146

0 commit comments

Comments
 (0)