Added possible_types option to ObjectType.Meta

Author: syrusakbary

graphene/types/objecttype.py

@@ -24,6 +24,7 @@ def __new__(cls, name, bases, attrs):
             name=name,
             description=trim_docstring(attrs.get('__doc__')),
             interfaces=(),
+            possible_types=(),
             default_resolver=None,
             local_fields=OrderedDict(),
         )
@@ -55,6 +56,11 @@ def __new__(cls, name, bases, attrs):
 
         cls = type.__new__(cls, name, bases, dict(attrs, _meta=options))
 
+        assert not (options.possible_types and cls.is_type_of), (
+            '{}.Meta.possible_types will cause type collision with {}.is_type_of. '
+            'Please use one or other.'
+        ).format(name, name)
+
         for interface in options.interfaces:
             interface.implements(cls)
 

graphene/types/tests/test_objecttype.py

@@ -184,3 +184,27 @@ class MyObjectType(ObjectType):
         '''
 
     assert MyObjectType._meta.description == "Documentation\n\nDocumentation line 2"
+
+
+def test_objecttype_with_possible_types():
+    class MyObjectType(ObjectType):
+        class Meta:
+            possible_types = (dict, )
+
+    assert MyObjectType._meta.possible_types == (dict, )
+
+
+def test_objecttype_with_possible_types_and_is_type_of_should_raise():
+    with pytest.raises(AssertionError) as excinfo:
+        class MyObjectType(ObjectType):
+            class Meta:
+                possible_types = (dict, )
+
+            @classmethod
+            def is_type_of(cls, root, context, info):
+                return False
+
+    assert str(excinfo.value) == (
+        'MyObjectType.Meta.possible_types will cause type collision with '
+        'MyObjectType.is_type_of. Please use one or other.'
+    )

graphene/types/tests/test_typemap.py

@@ -183,3 +183,18 @@ class MyObjectType(ObjectType):
     assert foo_field.args == {
         'bar_foo': GraphQLArgument(GraphQLString, out_name='bar_foo')
     }
+
+
+def test_objecttype_with_possible_types():
+    class MyObjectType(ObjectType):
+        '''Description'''
+        class Meta:
+            possible_types = (dict, )
+
+        foo_bar = String()
+
+    typemap = TypeMap([MyObjectType])
+    graphql_type = typemap['MyObjectType']
+    assert graphql_type.is_type_of
+    assert graphql_type.is_type_of({}, None, None) is True
+    assert graphql_type.is_type_of(MyObjectType(), None, None) is False

graphene/types/typemap.py

@@ -52,6 +52,10 @@ def resolve_type(resolve_type_func, map, type_name, root, context, info):
     return _type
 
 
+def is_type_of_from_possible_types(possible_types, root, context, info):
+    return isinstance(root, possible_types)
+
+
 class TypeMap(GraphQLTypeMap):
 
     def __init__(self, types, auto_camelcase=True, schema=None):
@@ -153,12 +157,17 @@ def interfaces():
                 interfaces.append(internal_type)
             return interfaces
 
+        if type._meta.possible_types:
+            is_type_of = partial(is_type_of_from_possible_types, type._meta.possible_types)
+        else:
+            is_type_of = type.is_type_of
+
         return GrapheneObjectType(
             graphene_type=type,
             name=type._meta.name,
             description=type._meta.description,
             fields=partial(self.construct_fields_for_type, map, type),
-            is_type_of=type.is_type_of,
+            is_type_of=is_type_of,
             interfaces=interfaces
         )