Improved logic in GroupNamedType

Author: syrusakbary

graphene/core/types/base.py

@@ -143,8 +143,11 @@ def get_named_type(self, schema, type):
         name = type.name or type.attname
         return name, schema.T(type)
 
+    def iter_types(self, schema):
+        return map(partial(self.get_named_type, schema), self.types)
+
     def internal_type(self, schema):
-        return OrderedDict(map(partial(self.get_named_type, schema), self.types))
+        return OrderedDict(self.iter_types(schema))
 
     def __len__(self):
         return len(self.types)

graphene/core/types/field.py

@@ -145,11 +145,9 @@ def internal_type(self, schema):
 
 
 class FieldsGroupType(GroupNamedType):
-    def internal_type(self, schema):
-        fields = []
+    def iter_types(self, schema):
         for field in sorted(self.types):
             try:
-                fields.append(self.get_named_type(schema, field))
+                yield self.get_named_type(schema, field)
             except SkipField:
                 continue
-        return OrderedDict(fields)