Added support for old behavior of get_node

Author: syrusakbary

graphene/contrib/django/tests/test_types.py

@@ -36,7 +36,7 @@ def test_django_interface():
 
 @patch('graphene.contrib.django.tests.models.Article.objects.get', return_value=Article(id=1))
 def test_django_get_node(get):
-    human = Human.get_node(1)
+    human = Human.get_node(1, None)
     get.assert_called_with(id=1)
     assert human.id == 1
 

graphene/contrib/django/types.py

@@ -67,7 +67,7 @@ class DjangoNode(BaseNode, DjangoInterface):
     id = GlobalIDField()
 
     @classmethod
-    def get_node(cls, id):
+    def get_node(cls, id, info=None):
         try:
             instance = cls._meta.model.objects.get(id=id)
             return cls(instance)

graphene/relay/tests/test_types.py

@@ -11,10 +11,32 @@ class OtherNode(relay.Node):
     name = graphene.String()
 
     @classmethod
-    def get_node(cls, id):
+    def get_node(cls, id, info):
         pass
 
 
+def test_works_old_get_node():
+    class Part(relay.Node):
+        x = graphene.String()
+
+        @classmethod
+        def get_node(cls, id):
+            return id
+
+    assert Part.get_node(1) == 1
+
+
+def test_works_old_static_get_node():
+    class Part(relay.Node):
+        x = graphene.String()
+
+        @staticmethod
+        def get_node(id):
+            return id
+
+    assert Part.get_node(1) == 1
+
+
 def test_field_no_contributed_raises_error():
     with raises(Exception) as excinfo:
         class Part(relay.Node):

graphene/relay/types.py

@@ -1,3 +1,5 @@
+import warnings
+from functools import wraps
 from graphql_relay.node.node import to_global_id
 
 from ..core.types import (Boolean, Field, InputObjectType, Interface, List,
@@ -73,8 +75,26 @@ class BaseNode(object):
     def _prepare_class(cls):
         from graphene.relay.utils import is_node
         if is_node(cls):
-            assert hasattr(
-                cls, 'get_node'), 'get_node classmethod not found in %s Node' % cls
+            get_node = getattr(cls, 'get_node')
+            assert get_node, 'get_node classmethod not found in %s Node' % cls
+            assert callable(get_node), 'get_node have to be callable'
+            args = 3
+            if isinstance(get_node, staticmethod):
+                args -= 1
+
+            if get_node.func_code.co_argcount < args:
+                warnings.warn("get_node will receive also the info arg"
+                              " in future versions of graphene".format(cls.__name__),
+                              FutureWarning)
+
+                @staticmethod
+                @wraps(get_node)
+                def wrapped_node(*node_args):
+                    if len(node_args) < args:
+                        node_args += (None, )
+                    return get_node(*node_args[:-1])
+
+                setattr(cls, 'get_node', wrapped_node)
 
     def to_global_id(self):
         type_name = self._meta.type_name