Fixed NonNull ordered errors in tests

Author: syrusakbary

graphql/execution/experimental/tests/test_nonnull.py

@@ -81,22 +81,34 @@ def nonNullPromiseNest(self):
 schema = GraphQLSchema(DataType)
 
 
+def order_errors(error):
+    locations = error['locations']
+    return (locations[0]['column'], locations[0]['line'])
+
+
 def check(doc, data, expected):
     ast = parse(doc)
     response = execute(schema, ast, data)
 
     if response.errors:
-
         result = {
             'data': response.data,
             'errors': [format_error(e) for e in response.errors]
         }
+        if result['errors'] != expected['errors']:
+            assert result['data'] == expected['data']
+            # Sometimes the fields resolves asynchronously, so
+            # we need to check that the errors are the same, but might be
+            # raised in a different order.
+            assert sorted(result['errors'], key=order_errors) == sorted(expected['errors'], key=order_errors)
+        else:
+            assert result == expected
     else:
         result = {
             'data': response.data
         }
 
-    assert result == expected
+        assert result == expected
 
 
 def test_nulls_a_nullable_field_that_throws_sync():

graphql/execution/tests/test_nonnull.py

@@ -81,6 +81,11 @@ def nonNullPromiseNest(self):
 schema = GraphQLSchema(DataType)
 
 
+def order_errors(error):
+    locations = error['locations']
+    return (locations[0]['column'], locations[0]['line'])
+
+
 def check(doc, data, expected):
     ast = parse(doc)
     response = execute(schema, ast, data)
@@ -90,12 +95,20 @@ def check(doc, data, expected):
             'data': response.data,
             'errors': [format_error(e) for e in response.errors]
         }
+        if result['errors'] != expected['errors']:
+            assert result['data'] == expected['data']
+            # Sometimes the fields resolves asynchronously, so
+            # we need to check that the errors are the same, but might be
+            # raised in a different order.
+            assert sorted(result['errors'], key=order_errors) == sorted(expected['errors'], key=order_errors)
+        else:
+            assert result == expected
     else:
         result = {
             'data': response.data
         }
 
-    assert result == expected
+        assert result == expected
 
 
 def test_nulls_a_nullable_field_that_throws_sync():