Skip to content

Commit 1fd1e20

Browse files
committed
Remove custom clone method and use copy.deepcopy
1 parent e7080bc commit 1fd1e20

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

graphql/core/language/visitor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from copy import copy
1+
from copy import copy, deepcopy
22
from collections import namedtuple
33
from . import ast
44

@@ -78,7 +78,7 @@ def visit(root, visitor, key_map=None):
7878
if isinstance(node, list):
7979
node[edit_key] = edit_value
8080
else:
81-
node = node.clone()
81+
node = deepcopy(node)
8282
setattr(node, edit_key, edit_value)
8383
index = stack.index
8484
keys = stack.keys

scripts/generate_ast.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ def end_type(self, typename):
5656
typename = remap_type(typename)
5757
self._print_slots()
5858
self._print_ctor()
59-
self._print_clone_method(typename)
6059
self._print_comparator(typename)
6160
self._print_repr(typename)
6261
self._fields = []
@@ -76,14 +75,6 @@ def __init__(self, {ctor_args}, loc=None):
7675
for type, name, nullable, plural in self._fields:
7776
print ''' self.{name} = {name}'''.format(name=snake(name))
7877

79-
def _print_clone_method(self, typename):
80-
print '''
81-
def clone(self):
82-
return {typename}('''.format(typename=typename)
83-
for type, name, nullable, plural in self._fields:
84-
print ''' {name}=self.{name},'''.format(name=snake(name))
85-
print ' )'
86-
8778
def _print_comparator(self, typename):
8879
print '''
8980
def __eq__(self, other):

0 commit comments

Comments
 (0)