[Validation] Parallelize validation rules.

Related GraphQL-js commit: graphql/graphql-js@9577041

Author: syrusakbary

graphql/core/validation/__init__.py

@@ -3,7 +3,7 @@
 from ..utils.type_info import TypeInfo
 from .context import ValidationContext
 from .rules import specified_rules
-from .visitor import ValidationVisitor
+from .visitor import ParallelVisitor, TypeInfoVisitor
 
 
 def validate(schema, ast, rules=specified_rules):
@@ -16,7 +16,6 @@ def validate(schema, ast, rules=specified_rules):
 
 def visit_using_rules(schema, type_info, ast, rules):
     context = ValidationContext(schema, ast, type_info)
-    rules = [rule(context) for rule in rules]
-    for instance in rules:
-        visit(ast, ValidationVisitor(instance, context, type_info))
+    visitors = [rule(context) for rule in rules]
+    visit(ast, TypeInfoVisitor(type_info, ParallelVisitor(visitors)))
     return context.get_errors()

graphql/core/validation/context.py

@@ -1,6 +1,7 @@
 from ..language.ast import FragmentDefinition, FragmentSpread, VariableDefinition, Variable, OperationDefinition
 from ..utils.type_info import TypeInfo
 from ..language.visitor import Visitor, visit
+from .visitor import TypeInfoVisitor
 
 
 class VariableUsage(object):
@@ -12,22 +13,18 @@ def __init__(self, node, type):
 
 
 class UsageVisitor(Visitor):
-    __slots__ = 'context', 'usages', 'type_info'
+    __slots__ = 'usages', 'type_info'
 
     def __init__(self, usages, type_info):
         self.usages = usages
         self.type_info = type_info
 
-    def enter(self, node, key, parent, path, ancestors):
-        self.type_info.enter(node)
-        if isinstance(node, VariableDefinition):
-            return False
-        elif isinstance(node, Variable):
-            usage = VariableUsage(node, type=self.type_info.get_input_type())
-            self.usages.append(usage)
+    def enter_VariableDefinition(self, node, key, parent, path, ancestors):
+        return False
 
-    def leave(self, node, key, parent, path, ancestors):
-        self.type_info.leave(node)
+    def enter_Variable(self, node, key, parent, path, ancestors):
+        usage = VariableUsage(node, type=self.type_info.get_input_type())
+        self.usages.append(usage)
 
 
 class ValidationContext(object):
@@ -58,7 +55,7 @@ def get_variable_usages(self, node):
         if usages is None:
             usages = []
             sub_visitor = UsageVisitor(usages, self._type_info)
-            visit(node, sub_visitor)
+            visit(node, TypeInfoVisitor(self._type_info, sub_visitor))
             self._variable_usages[node] = usages
 
         return usages

graphql/core/validation/visitor.py

@@ -1,24 +1,42 @@
 from ..language.visitor import Visitor
 
 
-class ValidationVisitor(Visitor):
-    __slots__ = 'context', 'instance', 'type_info'
+class TypeInfoVisitor(Visitor):
+    __slots__ = 'visitor', 'type_info'
 
-    def __init__(self, instance, context, type_info):
-        self.context = context
-        self.instance = instance
+    def __init__(self, type_info, visitor):
         self.type_info = type_info
+        self.visitor = visitor
 
     def enter(self, node, key, parent, path, ancestors):
         self.type_info.enter(node)
-        result = self.instance.enter(node, key, parent, path, ancestors)
+        result = self.visitor.enter(node, key, parent, path, ancestors)
         if result is False:
             self.type_info.leave(node)
-
-        return result
+            return False
 
     def leave(self, node, key, parent, path, ancestors):
-        result = self.instance.leave(node, key, parent, path, ancestors)
-
+        self.visitor.leave(node, key, parent, path, ancestors)
         self.type_info.leave(node)
-        return result
+
+
+class ParallelVisitor(Visitor):
+    __slots__ = 'skipping', 'visitors'
+
+    def __init__(self, visitors):
+        self.visitors = visitors
+        self.skipping = [None]*len(visitors)
+
+    def enter(self, node, key, parent, path, ancestors):
+        for i, visitor in enumerate(self.visitors):
+            if not self.skipping[i]:
+                result = visitor.enter(node, key, parent, path, ancestors)
+                if result is False:
+                    self.skipping[i] = node
+
+    def leave(self, node, key, parent, path, ancestors):
+        for i, visitor in enumerate(self.visitors):
+            if not self.skipping[i]:
+                visitor.leave(node, key, parent, path, ancestors)
+            else:
+                self.skipping[i] = None