Skip to content

Commit 93ed376

Browse files
committed
Make middleware methods static.
1 parent 57fba97 commit 93ed376

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

graphql/core/execution/middlewares/asyncio.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ def handle_future_result(future):
1717

1818

1919
class AsyncioExecutionMiddleware(object):
20-
def run_resolve_fn(self, resolver, original_resolver):
20+
@staticmethod
21+
def run_resolve_fn(resolver, original_resolver):
2122
result = resolver()
2223
if isinstance(result, Future) or iscoroutine(result):
2324
future = ensure_future(result)
@@ -27,7 +28,8 @@ def run_resolve_fn(self, resolver, original_resolver):
2728

2829
return result
2930

30-
def execution_result(self, executor):
31+
@staticmethod
32+
def execution_result(executor):
3133
future = Future()
3234
result = executor()
3335
assert isinstance(result, Deferred), 'Another middleware has converted the execution result ' \

graphql/core/execution/middlewares/gevent.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,17 @@ def resolve_something(context, _*):
3030

3131

3232
class GeventExecutionMiddleware(object):
33-
def run_resolve_fn(self, resolver, original_resolver):
33+
@staticmethod
34+
def run_resolve_fn(resolver, original_resolver):
3435
if resolver_has_tag(original_resolver, 'run_in_greenlet'):
3536
d = Deferred()
3637
spawn(_run_resolver_in_greenlet, d, resolver)
3738
return d
3839

3940
return resolver()
4041

41-
def execution_result(self, executor):
42+
@staticmethod
43+
def execution_result(executor):
4244
result = AsyncResult()
4345
deferred = executor()
4446
assert isinstance(deferred, Deferred), 'Another middleware has converted the execution result ' \

graphql/core/execution/middlewares/sync.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33

44

55
class SynchronousExecutionMiddleware(object):
6-
def run_resolve_fn(self, resolver, original_resolver):
6+
@staticmethod
7+
def run_resolve_fn(resolver, original_resolver):
78
result = resolver()
89
if isinstance(result, Deferred):
910
raise GraphQLError('You cannot return a Deferred from a resolver when using SynchronousExecutionMiddleware')
1011

1112
return result
1213

13-
def execution_result(self, executor):
14+
@staticmethod
15+
def execution_result(executor):
1416
result = executor()
1517
return result.result

0 commit comments

Comments
 (0)