Enforce import order (fix #49)

Author: dittos

.travis.yml

@@ -11,7 +11,8 @@ install:
 - pip install pytest>=2.7.3 --upgrade
 - pip install -e .
 script:
-- py.test --cov=graphql tests
 - flake8
+- import-order graphql
+- py.test --cov=graphql tests
 after_success:
 - coveralls

graphql/core/__init__.py

@@ -1,6 +1,6 @@
-from .execution import execute, ExecutionResult
-from .language.source import Source
+from .execution import ExecutionResult, execute
 from .language.parser import parse
+from .language.source import Source
 from .validation import validate
 
 

graphql/core/execution/__init__.py

@@ -1,27 +1,27 @@
 # -*- coding: utf-8 -*-
 import collections
 from ..error import GraphQLError, format_error
-from ..utils import type_from_ast, is_nullish
 from ..language import ast
-from .values import get_variable_values, get_argument_values
 from ..type.definition import (
-    GraphQLScalarType,
-    GraphQLObjectType,
-    GraphQLInterfaceType,
-    GraphQLUnionType,
     GraphQLEnumType,
+    GraphQLInterfaceType,
     GraphQLList,
     GraphQLNonNull,
+    GraphQLObjectType,
+    GraphQLScalarType,
+    GraphQLUnionType,
+)
+from ..type.directives import (
+    GraphQLIncludeDirective,
+    GraphQLSkipDirective,
 )
 from ..type.introspection import (
     SchemaMetaFieldDef,
     TypeMetaFieldDef,
     TypeNameMetaFieldDef,
 )
-from ..type.directives import (
-    GraphQLIncludeDirective,
-    GraphQLSkipDirective,
-)
+from ..utils import is_nullish, type_from_ast
+from .values import get_argument_values, get_variable_values
 
 Undefined = object()
 

graphql/core/execution/values.py

@@ -3,9 +3,15 @@
 from ..error import GraphQLError
 from ..language import ast
 from ..language.printer import print_ast
-from ..type import (GraphQLNonNull, GraphQLList, GraphQLInputObjectType,
-                    GraphQLScalarType, GraphQLEnumType, is_input_type)
-from ..utils import type_from_ast, is_nullish
+from ..type import (
+    GraphQLEnumType,
+    GraphQLInputObjectType,
+    GraphQLList,
+    GraphQLNonNull,
+    GraphQLScalarType,
+    is_input_type
+)
+from ..utils import is_nullish, type_from_ast
 
 __all__ = ['get_variable_values', 'get_argument_values']
 

graphql/core/language/parser.py

@@ -1,8 +1,8 @@
+from . import ast
 from ..compat import str_type
-from .source import Source
 from .error import LanguageError
-from .lexer import Lexer, TokenKind, get_token_kind_desc, get_token_desc
-from . import ast
+from .lexer import Lexer, TokenKind, get_token_desc, get_token_kind_desc
+from .source import Source
 
 __all__ = ['parse']
 

graphql/core/language/printer.py

@@ -1,5 +1,5 @@
 import json
-from .visitor import visit, Visitor
+from .visitor import Visitor, visit
 
 __all__ = ['print_ast']
 

graphql/core/language/visitor.py

@@ -1,5 +1,5 @@
-from copy import copy, deepcopy
 from collections import namedtuple
+from copy import copy, deepcopy
 from . import ast
 
 QUERY_DOCUMENT_KEYS = {

graphql/core/type/__init__.py

@@ -1,6 +1,5 @@
 # flake8: noqa
-from .schema import GraphQLSchema
-from .definition import (
+from .definition import (  # no import order
     GraphQLScalarType,
     GraphQLObjectType,
     GraphQLField,
@@ -15,10 +14,11 @@
     GraphQLNonNull,
     is_input_type,
 )
-from .scalars import (
+from .scalars import (  # no import order
     GraphQLInt,
     GraphQLFloat,
     GraphQLString,
     GraphQLBoolean,
     GraphQLID,
 )
+from .schema import GraphQLSchema

graphql/core/type/directives.py

@@ -1,4 +1,4 @@
-from .definition import GraphQLNonNull, GraphQLArgument
+from .definition import GraphQLArgument, GraphQLNonNull
 from .scalars import GraphQLBoolean
 
 

graphql/core/type/introspection.py

@@ -1,18 +1,18 @@
 import json
 from .definition import (
-    GraphQLObjectType,
-    GraphQLField,
-    GraphQLEnumType,
-    GraphQLList,
-    GraphQLNonNull,
     GraphQLArgument,
+    GraphQLEnumType,
     GraphQLEnumValue,
-    GraphQLInterfaceType,
-    GraphQLUnionType,
+    GraphQLField,
     GraphQLInputObjectType,
+    GraphQLInterfaceType,
+    GraphQLList,
+    GraphQLNonNull,
+    GraphQLObjectType,
     GraphQLScalarType,
+    GraphQLUnionType,
 )
-from .scalars import GraphQLString, GraphQLBoolean
+from .scalars import GraphQLBoolean, GraphQLString
 
 __Schema = GraphQLObjectType(
     '__Schema',