Skip to content

Commit 16d2ddb

Browse files
committed
Fix mypy issues
1 parent 2c9f5e1 commit 16d2ddb

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

graphql/validation/rules/known_argument_names.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
from typing import Dict, List, Union
1+
from typing import cast, Dict, List, Union
22

33
from ...error import GraphQLError
44
from ...language import (
5-
ArgumentNode, FieldNode, DirectiveDefinitionNode, DirectiveNode, SKIP)
5+
ArgumentNode, DirectiveDefinitionNode, DirectiveNode, SKIP)
66
from ...pyutils import quoted_or_list, suggestion_list
77
from ...type import specified_directives
88
from . import ASTValidationRule, SDLValidationContext, ValidationContext
@@ -48,7 +48,7 @@ def __init__(self, context: Union[
4848
schema = context.schema
4949
defined_directives = (
5050
schema.directives if schema else specified_directives)
51-
for directive in defined_directives:
51+
for directive in cast(List, defined_directives):
5252
directive_args[directive.name] = list(directive.args)
5353

5454
ast_definitions = context.document.definitions
@@ -100,4 +100,3 @@ def enter_argument(
100100
unknown_arg_message(
101101
arg_name, field_name, parent_type.name,
102102
suggestion_list(arg_name, known_args_names)), arg_node))
103-

graphql/validation/rules/provided_required_arguments.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
from typing import Dict, Union
1+
from typing import cast, Dict, List, Union
22

33
from ...error import GraphQLError
44
from ...language import (
55
DirectiveDefinitionNode, DirectiveNode, FieldNode,
6-
InputValueDefinitionNode, NonNullTypeNode, print_ast)
6+
InputValueDefinitionNode, NonNullTypeNode, TypeNode, print_ast)
77
from ...type import (
88
GraphQLArgument, is_required_argument, is_type, specified_directives)
99
from . import ASTValidationRule, SDLValidationContext, ValidationContext
@@ -38,12 +38,13 @@ class ProvidedRequiredArgumentsOnDirectivesRule(ASTValidationRule):
3838
def __init__(self, context: Union[
3939
ValidationContext, SDLValidationContext]) -> None:
4040
super().__init__(context)
41-
required_args_map: Dict[str, Dict[str, GraphQLArgument]] = {}
41+
required_args_map: Dict[str, Dict[str, Union[
42+
GraphQLArgument, InputValueDefinitionNode]]] = {}
4243

4344
schema = context.schema
4445
defined_directives = (
4546
schema.directives if schema else specified_directives)
46-
for directive in defined_directives:
47+
for directive in cast(List, defined_directives):
4748
required_args_map[directive.name] = {
4849
name: arg for name, arg in directive.args.items()
4950
if is_required_argument(arg)}
@@ -72,7 +73,8 @@ def leave_directive(self, directive_node: DirectiveNode, *_args):
7273
self.report_error(GraphQLError(
7374
missing_directive_arg_message(
7475
directive_name, arg_name, str(arg_type)
75-
if is_type(arg_type) else print_ast(arg_type)),
76+
if is_type(arg_type)
77+
else print_ast(cast(TypeNode, arg_type))),
7678
[directive_node]))
7779

7880

tests/validation/test_known_argument_names.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ def unknown_args_deeply():
153153
unknown_arg('unknown', 'doesKnowCommand', 'Dog', [], 9, 37)
154154
])
155155

156-
157156
def describe_within_sdl():
158157

159158
def known_arg_on_directive_inside_sdl():
@@ -180,7 +179,7 @@ def misspelled_arg_name_is_reported_on_directive_defined_inside_sdl():
180179
type Query {
181180
foo: String @test(agr: "")
182181
}
183-
182+
184183
directive @test(arg: String) on FIELD_DEFINITION
185184
""") == [
186185
unknown_directive_arg('agr', 'test', ['arg'], 3, 37)]

0 commit comments

Comments
 (0)