Improve coverage for lexicographic_sort_schema

Replicates graphql/graphql-js@784e71b

Author: Cito

graphql/execution/execute.py

@@ -785,7 +785,7 @@ def complete_value(
             )
 
         # Not reachable. All possible output types have been considered.
-        raise TypeError(
+        raise TypeError(  # pragma: no cover
             f"Cannot complete value of unexpected type '{inspect(return_type)}'."
         )
 

graphql/utilities/build_ast_schema.py

@@ -280,7 +280,9 @@ def build_type(self, ast_node: TypeDefinitionNode) -> GraphQLNamedType:
         }.get(ast_node.kind)
         if not method:
             # Not reachable. All possible type definition nodes have been considered.
-            raise TypeError(f"Type kind '{ast_node.kind}' not supported.")
+            raise TypeError(  # pragma: no cover
+                f"Type kind '{ast_node.kind}' not supported."
+            )
         return method(ast_node)  # type: ignore
 
     def _make_type_def(self, ast_node: ObjectTypeDefinitionNode) -> GraphQLObjectType:

graphql/utilities/extend_schema.py

@@ -163,7 +163,7 @@ def extend_named_type(type_: GraphQLNamedType) -> GraphQLNamedType:
             type_ = cast(GraphQLInputObjectType, type_)
             return extend_input_object_type(type_)
         # Not reachable. All possible types have been considered.
-        raise TypeError(f"Type {type_} not supported.")
+        raise TypeError(f"Type {type_} not supported.")  # pragma: no cover
 
     def extend_directive(directive: GraphQLDirective) -> GraphQLDirective:
         kwargs = directive.to_kwargs()

graphql/utilities/lexicographic_sort_schema.py

@@ -129,7 +129,8 @@ def sort_named_type(type_: GraphQLNamedType) -> GraphQLNamedType:
             input_object_type = cast(GraphQLInputObjectType, type_)
             kwargs.update(fields=lambda: sort_input_fields(input_object_type.fields))
             return GraphQLInputObjectType(**kwargs)
-        raise TypeError(f"Unknown type: '{type_}'")
+        # Not reachable. All possible type definition nodes have been considered.
+        raise TypeError(f"Unknown type: '{type_}'")  # pragma: no cover
 
     type_map: Dict[str, GraphQLNamedType] = {
         type_.name: sort_named_type(type_)

tests/utilities/test_lexicographic_sort_schema.py

@@ -12,21 +12,21 @@ def sort_fields():
         sorted_sdl = sort_sdl(
             """
             input Bar {
-              barB: String
+              barB: String!
               barA: String
-              barC: String
+              barC: [String]
             }
 
             interface FooInterface {
-              fooB: String
+              fooB: String!
               fooA: String
-              fooC: String
+              fooC: [String]
             }
 
             type FooType implements FooInterface {
-              fooC: String
+              fooC: [String]
               fooA: String
-              fooB: String
+              fooB: String!
             }
 
             type Query {
@@ -39,20 +39,20 @@ def sort_fields():
             """
             input Bar {
               barA: String
-              barB: String
-              barC: String
+              barB: String!
+              barC: [String]
             }
 
             interface FooInterface {
               fooA: String
-              fooB: String
-              fooC: String
+              fooB: String!
+              fooC: [String]
             }
 
             type FooType implements FooInterface {
               fooA: String
-              fooB: String
-              fooC: String
+              fooB: String!
+              fooC: [String]
             }
 
             type Query {
@@ -180,15 +180,15 @@ def sort_field_arguments():
         sorted_sdl = sort_sdl(
             """
             type Query {
-              dummy(argB: Int, argA: String, argC: Float): ID
+              dummy(argB: Int!, argA: String, argC: [Float]): ID
             }
             """
         )
 
         assert sorted_sdl == dedent(
             """
             type Query {
-              dummy(argA: String, argB: Int, argC: Float): ID
+              dummy(argA: String, argB: Int!, argC: [Float]): ID
             }
             """
         )