Skip to content

Commit 3eb73f8

Browse files
committed
test_known_directives: remove dependency on harness schema
Replicates graphql/graphql-js@632c0d8
1 parent 4315568 commit 3eb73f8

File tree

2 files changed

+26
-15
lines changed

2 files changed

+26
-15
lines changed

tests/validation/harness.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,7 @@
137137
query: QueryRoot
138138
}
139139
140-
directive @onQuery on QUERY
141-
directive @onMutation on MUTATION
142-
directive @onSubscription on SUBSCRIPTION
143140
directive @onField on FIELD
144-
directive @onFragmentDefinition on FRAGMENT_DEFINITION
145-
directive @onFragmentSpread on FRAGMENT_SPREAD
146-
directive @onInlineFragment on INLINE_FRAGMENT
147-
directive @onVariableDefinition on VARIABLE_DEFINITION
148141
"""
149142
)
150143

tests/validation/test_known_directives.py

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,22 @@
55

66
from .harness import assert_validation_errors, assert_sdl_validation_errors
77

8-
assert_errors = partial(assert_validation_errors, KnownDirectivesRule)
9-
10-
assert_valid = partial(assert_errors, errors=[])
11-
12-
assert_sdl_errors = partial(assert_sdl_validation_errors, KnownDirectivesRule)
13-
14-
assert_sdl_valid = partial(assert_sdl_errors, errors=[])
15-
8+
schema_with_directives = build_schema(
9+
"""
10+
type Query {
11+
dummy: String
12+
}
13+
14+
directive @onQuery on QUERY
15+
directive @onMutation on MUTATION
16+
directive @onSubscription on SUBSCRIPTION
17+
directive @onField on FIELD
18+
directive @onFragmentDefinition on FRAGMENT_DEFINITION
19+
directive @onFragmentSpread on FRAGMENT_SPREAD
20+
directive @onInlineFragment on INLINE_FRAGMENT
21+
directive @onVariableDefinition on VARIABLE_DEFINITION
22+
"""
23+
)
1624

1725
schema_with_sdl_directives = build_schema(
1826
"""
@@ -30,6 +38,16 @@
3038
"""
3139
)
3240

41+
assert_errors = partial(
42+
assert_validation_errors, KnownDirectivesRule, schema=schema_with_directives
43+
)
44+
45+
assert_valid = partial(assert_errors, errors=[])
46+
47+
assert_sdl_errors = partial(assert_sdl_validation_errors, KnownDirectivesRule)
48+
49+
assert_sdl_valid = partial(assert_sdl_errors, errors=[])
50+
3351

3452
def describe_known_directives():
3553
def with_no_directives():

0 commit comments

Comments
 (0)