build_ast_schema: should match order of default types and directives

Replicates graphql/graphql-js@96c2d06

Author: Cito

src/graphql/utilities/build_ast_schema.py

@@ -1,17 +1,7 @@
 from typing import Union
 
-from ..language import (
-    DocumentNode,
-    Source,
-    parse,
-)
-from ..type import (
-    GraphQLDeprecatedDirective,
-    GraphQLIncludeDirective,
-    GraphQLSchema,
-    GraphQLSkipDirective,
-    GraphQLSpecifiedByDirective,
-)
+from ..language import DocumentNode, Source, parse
+from ..type import GraphQLSchema, specified_directives
 from .extend_schema import extend_schema_impl
 
 __all__ = [
@@ -74,14 +64,9 @@ def build_ast_schema(
 
     directives = schema_kwargs["directives"]
     # If specified directives were not explicitly declared, add them.
-    if not any(directive.name == "skip" for directive in directives):
-        directives.append(GraphQLSkipDirective)
-    if not any(directive.name == "include" for directive in directives):
-        directives.append(GraphQLIncludeDirective)
-    if not any(directive.name == "deprecated" for directive in directives):
-        directives.append(GraphQLDeprecatedDirective)
-    if not any(directive.name == "specifiedBy" for directive in directives):
-        directives.append(GraphQLSpecifiedByDirective)
+    for std_directive in specified_directives:
+        if all(directive.name != std_directive.name for directive in directives):
+            directives.append(std_directive)
 
     return GraphQLSchema(**schema_kwargs)
 

tests/utilities/test_build_ast_schema.py

@@ -8,6 +8,7 @@
 from graphql.type import (
     GraphQLDeprecatedDirective,
     GraphQLIncludeDirective,
+    GraphQLSchema,
     GraphQLSkipDirective,
     GraphQLSpecifiedByDirective,
     GraphQLBoolean,
@@ -114,6 +115,13 @@ def ignores_non_type_system_definitions():
             """
         build_schema(sdl)
 
+    def match_order_of_default_types_and_directives():
+        schema = GraphQLSchema()
+        sdl_schema = build_ast_schema(DocumentNode(definitions=[]))
+
+        assert sdl_schema.directives == schema.directives
+        assert sdl_schema.type_map == schema.type_map
+
     def empty_type():
         sdl = dedent(
             """