ASTValidation covers all validation rules that do not use Schema

Replicates graphql/graphql-js@93efa96

Author: Cito

graphql/validation/rules/no_fragment_cycles.py

@@ -2,7 +2,7 @@
 
 from ...error import GraphQLError
 from ...language import FragmentDefinitionNode, FragmentSpreadNode
-from . import ValidationContext, ValidationRule
+from . import ASTValidationContext, ASTValidationRule
 
 __all__ = ["NoFragmentCyclesRule", "cycle_error_message"]
 
@@ -12,10 +12,10 @@ def cycle_error_message(frag_name: str, spread_names: List[str]) -> str:
     return f"Cannot spread fragment '{frag_name}' within itself{via}."
 
 
-class NoFragmentCyclesRule(ValidationRule):
+class NoFragmentCyclesRule(ASTValidationRule):
     """No fragment cycles"""
 
-    def __init__(self, context: ValidationContext) -> None:
+    def __init__(self, context: ASTValidationContext) -> None:
         super().__init__(context)
         # Tracks already visited fragments to maintain O(N) and to ensure that
         # cycles are not redundantly reported.

graphql/validation/rules/no_unused_fragments.py

@@ -2,7 +2,7 @@
 
 from ...error import GraphQLError
 from ...language import FragmentDefinitionNode, OperationDefinitionNode
-from . import ValidationContext, ValidationRule
+from . import ASTValidationContext, ASTValidationRule
 
 __all__ = ["NoUnusedFragmentsRule", "unused_fragment_message"]
 
@@ -11,14 +11,14 @@ def unused_fragment_message(frag_name: str) -> str:
     return f"Fragment '{frag_name}' is never used."
 
 
-class NoUnusedFragmentsRule(ValidationRule):
+class NoUnusedFragmentsRule(ASTValidationRule):
     """No unused fragments
 
     A GraphQL document is only valid if all fragment definitions are spread within
     operations, or spread within other fragments spread within operations.
     """
 
-    def __init__(self, context: ValidationContext) -> None:
+    def __init__(self, context: ASTValidationContext) -> None:
         super().__init__(context)
         self.operation_defs: List[OperationDefinitionNode] = []
         self.fragment_defs: List[FragmentDefinitionNode] = []

graphql/validation/validation_context.py

@@ -67,51 +67,14 @@ class ASTValidationContext:
     def __init__(self, ast: DocumentNode) -> None:
         self.document = ast
         self.errors = []
-
-    def report_error(self, error: GraphQLError):
-        self.errors.append(error)
-
-
-class SDLValidationContext(ASTValidationContext):
-    """Utility class providing a context for validation of an SDL ast.
-
-    An instance of this class is passed as the context attribute to all Validators,
-    allowing access to commonly useful contextual information from within a validation
-    rule.
-    """
-
-    schema: Optional[GraphQLSchema]
-
-    def __init__(self, ast: DocumentNode, schema: GraphQLSchema = None) -> None:
-        super().__init__(ast)
-        self.schema = schema
-
-
-class ValidationContext(ASTValidationContext):
-    """Utility class providing a context for validation using a GraphQL schema.
-
-    An instance of this class is passed as the context attribute to all Validators,
-    allowing access to commonly useful contextual information from within a validation
-    rule.
-    """
-
-    schema: GraphQLSchema
-
-    def __init__(
-        self, schema: GraphQLSchema, ast: DocumentNode, type_info: TypeInfo
-    ) -> None:
-        super().__init__(ast)
-        self.schema = schema
-        self._type_info = type_info
         self._fragments: Optional[Dict[str, FragmentDefinitionNode]] = None
         self._fragment_spreads: Dict[SelectionSetNode, List[FragmentSpreadNode]] = {}
         self._recursively_referenced_fragments: Dict[
             OperationDefinitionNode, List[FragmentDefinitionNode]
         ] = {}
-        self._variable_usages: Dict[NodeWithSelectionSet, List[VariableUsage]] = {}
-        self._recursive_variable_usages: Dict[
-            OperationDefinitionNode, List[VariableUsage]
-        ] = {}
+
+    def report_error(self, error: GraphQLError):
+        self.errors.append(error)
 
     def get_fragment(self, name: str) -> Optional[FragmentDefinitionNode]:
         fragments = self._fragments
@@ -172,6 +135,43 @@ def get_recursively_referenced_fragments(
             self._recursively_referenced_fragments[operation] = fragments
         return fragments
 
+
+class SDLValidationContext(ASTValidationContext):
+    """Utility class providing a context for validation of an SDL ast.
+
+    An instance of this class is passed as the context attribute to all Validators,
+    allowing access to commonly useful contextual information from within a validation
+    rule.
+    """
+
+    schema: Optional[GraphQLSchema]
+
+    def __init__(self, ast: DocumentNode, schema: GraphQLSchema = None) -> None:
+        super().__init__(ast)
+        self.schema = schema
+
+
+class ValidationContext(ASTValidationContext):
+    """Utility class providing a context for validation using a GraphQL schema.
+
+    An instance of this class is passed as the context attribute to all Validators,
+    allowing access to commonly useful contextual information from within a validation
+    rule.
+    """
+
+    schema: GraphQLSchema
+
+    def __init__(
+        self, schema: GraphQLSchema, ast: DocumentNode, type_info: TypeInfo
+    ) -> None:
+        super().__init__(ast)
+        self.schema = schema
+        self._type_info = type_info
+        self._variable_usages: Dict[NodeWithSelectionSet, List[VariableUsage]] = {}
+        self._recursive_variable_usages: Dict[
+            OperationDefinitionNode, List[VariableUsage]
+        ] = {}
+
     def get_variable_usages(self, node: NodeWithSelectionSet) -> List[VariableUsage]:
         usages = self._variable_usages.get(node)
         if usages is None: