Skip to content

Commit 9c21478

Browse files
committed
Simplify build_ast_schema implementation
Replicates graphql/graphql-js@070121c
1 parent bac1fae commit 9c21478

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

graphql/utilities/build_ast_schema.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ def build_ast_schema(
9393
assert_valid_sdl(document_ast)
9494

9595
schema_def: Optional[SchemaDefinitionNode] = None
96-
type_defs: List[TypeDefinitionNode] = []
97-
append_type_def = type_defs.append
9896
node_map: TypeDefinitionsMap = {}
9997
directive_defs: List[DirectiveDefinitionNode] = []
10098
append_directive_def = directive_defs.append
@@ -103,9 +101,7 @@ def build_ast_schema(
103101
schema_def = def_
104102
elif isinstance(def_, TypeDefinitionNode):
105103
def_ = cast(TypeDefinitionNode, def_)
106-
type_name = def_.name.value
107-
append_type_def(def_)
108-
node_map[type_name] = def_
104+
node_map[def_.name.value] = def_
109105
elif isinstance(def_, DirectiveDefinitionNode):
110106
append_directive_def(def_)
111107

@@ -158,7 +154,7 @@ def resolve_type(type_ref: NamedTypeNode):
158154
)
159155
if subscription_type
160156
else None,
161-
types=[definition_builder.build_type(node) for node in type_defs],
157+
types=[definition_builder.build_type(node) for node in node_map.values()],
162158
directives=directives,
163159
ast_node=schema_def,
164160
assume_valid=assume_valid,

0 commit comments

Comments
 (0)