Skip to content

Commit ac56523

Browse files
committed
Fix coverage tests
1 parent b4f8261 commit ac56523

File tree

3 files changed

+10
-33
lines changed

3 files changed

+10
-33
lines changed

src/graphql/execution/execute.py

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1645,7 +1645,7 @@ async def execute_stream_async_iterator_item(
16451645
) -> Any:
16461646
"""Execute stream iterator item."""
16471647
if async_iterator in self._canceled_iterators:
1648-
raise StopAsyncIteration
1648+
raise StopAsyncIteration # pragma: no cover
16491649
try:
16501650
item = await anext(async_iterator)
16511651
except StopAsyncIteration as raw_error:
@@ -1682,7 +1682,6 @@ async def execute_stream_async_iterator(
16821682
parent_context: IncrementalDataRecord | None = None,
16831683
) -> None:
16841684
"""Execute stream iterator."""
1685-
is_awaitable = self.is_awaitable
16861685
incremental_publisher = self.incremental_publisher
16871686
index = initial_index
16881687
previous_incremental_data_record = parent_context
@@ -1722,35 +1721,10 @@ async def execute_stream_async_iterator(
17221721
except StopAsyncIteration:
17231722
done = True
17241723

1725-
if is_awaitable(completed_item):
1726-
1727-
async def await_completed_item(
1728-
incremental_data_record: StreamItemsRecord, completed_item: Any
1729-
) -> None:
1730-
try:
1731-
value = await completed_item
1732-
except GraphQLError as error:
1733-
incremental_publisher.add_field_error(
1734-
incremental_data_record, error
1735-
)
1736-
incremental_publisher.filter(path, incremental_data_record)
1737-
incremental_publisher.complete_stream_items_record(
1738-
incremental_data_record, None
1739-
)
1740-
else:
1741-
incremental_publisher.complete_stream_items_record(
1742-
incremental_data_record, [value]
1743-
)
1744-
1745-
self.add_task(
1746-
await_completed_item(incremental_data_record, completed_item)
1747-
)
1748-
1749-
else:
1750-
incremental_publisher.complete_stream_items_record(
1751-
incremental_data_record,
1752-
[completed_item],
1753-
)
1724+
incremental_publisher.complete_stream_items_record(
1725+
incremental_data_record,
1726+
[completed_item],
1727+
)
17541728

17551729
if done:
17561730
break

src/graphql/execution/incremental_publisher.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,9 @@ async def subscribe(
407407
finally:
408408
close_async_iterators = []
409409
for incremental_data_record in pending:
410-
if isinstance(incremental_data_record, StreamItemsRecord):
410+
if isinstance(
411+
incremental_data_record, StreamItemsRecord
412+
): # pragma: no cover
411413
async_iterator = incremental_data_record.async_iterator
412414
if async_iterator:
413415
try:
@@ -508,7 +510,7 @@ def filter(
508510
if async_iterator:
509511
try:
510512
close_async_iterator = async_iterator.aclose() # type:ignore
511-
except AttributeError:
513+
except AttributeError: # pragma: no cover
512514
pass
513515
else:
514516
self._add_task(close_async_iterator)

tests/execution/test_executor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,7 @@ def resolve_error(*_args):
617617
],
618618
)
619619

620+
@pytest.mark.filterwarnings("ignore:.* was never awaited:RuntimeWarning")
620621
def uses_the_inline_operation_if_no_operation_name_is_provided():
621622
schema = GraphQLSchema(
622623
GraphQLObjectType("Type", {"a": GraphQLField(GraphQLString)})

0 commit comments

Comments
 (0)