Fix AttributeError on exception with field source
#240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @kimjh12. Some questions to help me understand this better:
|
|
Hi @kimjh12 I am planning to do some maintenance on GraphQL-core next week, so I'd appreciate your feedback to fix this properly. |
trying to fix below error, which happens if the handler raises an
custom exception with `source` field inside
```
locations: list[SourceLocation] | None = [
> source.get_location(pos) for pos in positions
^^^^^^^^^^^^^^^^^^^
]
E AttributeError: 'str' object has no attribute 'get_location'
.tox/py312/lib/python3.12/site-packages/graphql/error/graphql_error.py:161: AttributeError
```
Yes, the issue was with my team's code. I updated the diff, thanks |
CodSpeed Performance ReportMerging #240 will not alter performanceComparing Summary
|
Cito
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to fix below error, which happens if the handler raises an custom exception with
sourcefield inside