WIP: Remove most uses of extern crate

Also removes the dependency on skeptic.

TODO:

- Document how to require serde now.

Author: tomhoule

README.md

@@ -33,12 +33,9 @@ A typed GraphQL client library for Rust.
 
 - We now have everything we need to derive Rust types for our query. This is achieved through a procedural macro, as in the following snippet:
 
-  ```rust,skt-empty-main
-  extern crate serde;
-  #[macro_use]
-  extern crate serde_derive;
-  #[macro_use]
-  extern crate graphql_client;
+  ```rust
+  use serde::{Serialize, Deserialize};
+  use graphql_client::GraphQLQuery;
 
   // The paths are relative to the directory where your `Cargo.toml` is located.
   // Both json and the GraphQL schema language are supported as sources for the schema
@@ -60,12 +57,7 @@ A typed GraphQL client library for Rust.
 
 * We now need to create the complete payload that we are going to send to the server. For convenience, the [GraphQLQuery trait](https://docs.rs/graphql_client/latest/graphql_client/trait.GraphQLQuery.html), is implemented for the struct under derive, so a complete query body can be created this way:
 
-  ```rust,skt-empty-main
-  extern crate failure;
-  #[macro_use]
-  extern crate graphql_client;
-  extern crate reqwest;
-
+  ```rust
   use graphql_client::{GraphQLQuery, Response};
 
   #[derive(GraphQLQuery)]
@@ -95,9 +87,8 @@ A typed GraphQL client library for Rust.
 
 The generated response types always derive `serde::Deserialize` but you may want to print them (`Debug`), compare them (`PartialEq`) or derive any other trait on it. You can achieve this with the `response_derives` option of the `graphql` attribute. Example:
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(
@@ -117,9 +108,8 @@ The generated code will reference the scalar types as defined in the server sche
 The generated code has support for [`@deprecated`](http://facebook.github.io/graphql/June2018/#sec-Field-Deprecation)
 field annotations. You can configure how deprecations are handled via the `deprecated` argument in the `GraphQLQuery` derive:
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(
@@ -145,9 +135,8 @@ You can write multiple operations in one query document (one `.graphql` file). Y
 
 Note that the struct and the operation in the GraphQL file *must* have the same name. We enforce this to make the generated code more predictable.
 
-```rust,skt-empty-main
-#[macro_use]
-extern crate graphql_client;
+```rust
+use graphql_client::GraphQLQuery;
 
 #[derive(GraphQLQuery)]
 #[graphql(

examples/example_module/src/lib.rs

@@ -1,9 +1,4 @@
-extern crate serde;
-#[macro_use]
-extern crate serde_derive;
-#[macro_use]
-extern crate graphql_client;
-
+use graphql_client::*;
 pub mod custom_scalars;
 
 use custom_scalars::*;

examples/github/src/main.rs

@@ -1,21 +1,8 @@
-extern crate dotenv;
-extern crate envy;
-#[macro_use]
-extern crate failure;
-extern crate graphql_client;
-#[macro_use]
-extern crate log;
-extern crate env_logger;
-extern crate reqwest;
-extern crate serde;
-extern crate serde_json;
-#[macro_use]
-extern crate serde_derive;
-extern crate structopt;
-#[macro_use]
-extern crate prettytable;
-
+use failure::*;
 use graphql_client::*;
+use log::*;
+use prettytable::*;
+use serde::*;
 use structopt::StructOpt;
 
 type URI = String;

examples/web/Cargo.toml

@@ -13,8 +13,7 @@ crate-type = ["cdylib"]
 [dependencies]
 graphql_client_web = { path = "../../graphql_client_web" }
 wasm-bindgen = "0.2.12"
-serde = "1.0.67"
-serde_derive = "1.0.67"
+serde = { version = "1.0.67", features = ["derive"] }
 serde_json = "1.0.22"
 lazy_static = "1.0.1"
 js-sys = "0.3.6"

examples/web/src/lib.rs

@@ -1,13 +1,11 @@
 use futures::Future;
+use graphql_client_web::*;
 use lazy_static::*;
 use std::cell::RefCell;
 use std::sync::Mutex;
-
 use wasm_bindgen::prelude::*;
 use wasm_bindgen_futures::future_to_promise;
 
-use graphql_client_web::*;
-
 #[derive(GraphQLQuery)]
 #[graphql(
     schema_path = "schema.json",

graphql_client/Cargo.toml

@@ -12,12 +12,5 @@ edition = "2018"
 [dependencies]
 failure = "0.1"
 graphql_query_derive = {path = "../graphql_query_derive", version = "0.7.1" }
-serde = "^1.0.78"
-serde_derive = "1.0"
+serde = { version = "^1.0.78", features = ["derive"] }
 serde_json = "1.0"
-
-[build-dependencies]
-skeptic = "0.13.4"
-
-[dev-dependencies]
-skeptic = "0.13.4"

graphql_client/build.rs

@@ -4,11 +4,10 @@
 
 #![deny(warnings)]
 #![deny(missing_docs)]
+#![deny(rust_2018_idioms)]
 
-use serde;
-#[macro_use]
-extern crate serde_derive;
 pub use graphql_query_derive;
+use serde::*;
 
 #[cfg(test)]
 use serde_json::json;
@@ -26,14 +25,8 @@ use std::fmt::{self, Display};
 /// Example:
 ///
 /// ```
-/// extern crate failure;
-/// #[macro_use]
-/// extern crate graphql_client;
-/// #[macro_use]
-/// extern crate serde_derive;
-/// #[macro_use]
-/// extern crate serde_json;
-/// extern crate serde;
+/// use graphql_client::*;
+/// use serde_json::json;
 ///
 /// #[derive(GraphQLQuery)]
 /// #[graphql(
@@ -127,12 +120,9 @@ impl Display for PathFragment {
 ///
 ///
 /// ```
-/// # extern crate failure;
-/// # #[macro_use]
-/// # extern crate serde_json;
-/// # extern crate graphql_client;
-/// # #[macro_use]
-/// # extern crate serde_derive;
+/// # use serde_json::json;
+/// # use serde::Deserialize;
+/// # use graphql_client::GraphQLQuery;
 /// #
 /// # #[derive(Debug, Deserialize, PartialEq)]
 /// # struct ResponseData {
@@ -236,12 +226,9 @@ impl Display for Error {
 /// [Spec](https://github.com/facebook/graphql/blob/master/spec/Section%207%20--%20Response.md)
 ///
 /// ```
-/// # extern crate failure;
-/// # #[macro_use]
-/// # extern crate serde_json;
-/// # extern crate graphql_client;
-/// # #[macro_use]
-/// # extern crate serde_derive;
+/// # use serde_json::json;
+/// # use serde::Deserialize;
+/// # use graphql_client::GraphQLQuery;
 /// #
 /// # #[derive(Debug, Deserialize, PartialEq)]
 /// # struct User {

graphql_client/src/lib.rs

@@ -1,10 +1,5 @@
-#[macro_use]
-extern crate graphql_client;
-
-#[macro_use]
-extern crate serde_derive;
-#[macro_use]
-extern crate serde_json;
+use graphql_client::*;
+use serde_json::*;
 
 #[derive(GraphQLQuery)]
 #[graphql(

graphql_client/tests/alias.rs

@@ -1,10 +1,5 @@
-#[macro_use]
-extern crate graphql_client;
-extern crate serde;
-#[macro_use]
-extern crate serde_derive;
-#[macro_use]
-extern crate serde_json;
+use graphql_client::*;
+use serde_json::json;
 
 use std::net::Ipv4Addr;