Skip to content

split rustfmt and clippy checks into separate jobs #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

split rustfmt and clippy checks into separate jobs #472

merged 1 commit into from
Jan 31, 2025

Conversation

danieleades
Copy link
Contributor

  • splits the two lint jobs into separate targets
  • pins the clippy toolchain to ensure no surprises

@tomhoule
Copy link
Member

Hi @danieleades . I'm going to take on more active maintainership of this crate again, and this PR looks good. Do you want to finish it?

@danieleades danieleades marked this pull request as ready for review January 31, 2025 07:46
@danieleades
Copy link
Contributor Author

Hi @danieleades . I'm going to take on more active maintainership of this crate again, and this PR looks good. Do you want to finish it?

ready for review now

@tomhoule
Copy link
Member

tomhoule commented Jan 31, 2025 •
edited
Loading

Looks good to me!

@tomhoule tomhoule merged commit d7a5143 into graphql-rust:main Jan 31, 2025
9 of 10 checks passed
@danieleades danieleades deleted the ci-lint branch January 31, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danieleades @tomhoule